Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1136273003: [Android] Remove v14 resource verification entirely. (Closed)

Created:
5 years, 7 months ago by Kibeom Kim (inactive)
Modified:
5 years, 7 months ago
Reviewers:
cjhopman, newt (away)
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org, Yaron
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Remove v14 resource verification entirely. BUG=487391 Committed: https://crrev.com/6edecc8ca40abd2a82edc78f8d51a1b59543cbca Cr-Commit-Position: refs/heads/master@{#330439}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : removed AssertNoDeprecatedAttributesInDir #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -91 lines) Patch
M build/android/gyp/generate_v14_compatible_resources.py View 1 2 3 4 5 chunks +23 lines, -63 lines 0 comments Download
M build/android/gyp/process_resources.py View 1 2 2 chunks +1 line, -8 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M build/config/android/rules.gni View 1 2 3 2 chunks +3 lines, -8 lines 0 comments Download
M build/java.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
M build/java_apk.gypi View 1 2 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136273003/20001
5 years, 7 months ago (2015-05-15 22:04:57 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/53745) ios_dbg_simulator_ninja on ...
5 years, 7 months ago (2015-05-15 22:12:30 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136273003/60001
5 years, 7 months ago (2015-05-18 20:23:55 UTC) #7
Kibeom Kim (inactive)
5 years, 7 months ago (2015-05-18 20:59:02 UTC) #9
newt (away)
lgtm after comment https://codereview.chromium.org/1136273003/diff/60001/build/android/gyp/generate_v14_compatible_resources.py File build/android/gyp/generate_v14_compatible_resources.py (right): https://codereview.chromium.org/1136273003/diff/60001/build/android/gyp/generate_v14_compatible_resources.py#newcode234 build/android/gyp/generate_v14_compatible_resources.py:234: def AssertNoDeprecatedAttributesInDir(input_dir, resource_type): can you remove ...
5 years, 7 months ago (2015-05-18 21:03:41 UTC) #10
Kibeom Kim (inactive)
https://codereview.chromium.org/1136273003/diff/60001/build/android/gyp/generate_v14_compatible_resources.py File build/android/gyp/generate_v14_compatible_resources.py (right): https://codereview.chromium.org/1136273003/diff/60001/build/android/gyp/generate_v14_compatible_resources.py#newcode234 build/android/gyp/generate_v14_compatible_resources.py:234: def AssertNoDeprecatedAttributesInDir(input_dir, resource_type): On 2015/05/18 21:03:41, newt wrote: > ...
5 years, 7 months ago (2015-05-18 21:07:38 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136273003/80001
5 years, 7 months ago (2015-05-18 21:08:55 UTC) #14
cjhopman
lgtm
5 years, 7 months ago (2015-05-18 21:26:51 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136273003/80001
5 years, 7 months ago (2015-05-18 21:27:52 UTC) #18
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 7 months ago (2015-05-18 22:13:01 UTC) #19
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 22:44:40 UTC) #20
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/6edecc8ca40abd2a82edc78f8d51a1b59543cbca
Cr-Commit-Position: refs/heads/master@{#330439}

Powered by Google App Engine
This is Rietveld 408576698