Implement the ability to obliterate a storage partition from disk.

content/public/browser/content_browser_client.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_
 #define CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_
 
 #include <string>
 #include <utility>
 #include <vector>
@@ skipping 272 matching lines @@
   // domain, partitions can be uniquely identified by the combination of
   // |partition_name| and |in_memory| values. When a partition is not to be
   // persisted, the |in_memory| value must be set to true.
   virtual void GetStoragePartitionConfigForSite(
       content::BrowserContext* browser_context,
       const GURL& site,
       std::string* partition_domain,
       std::string* partition_name,
       bool* in_memory);
 
+  // Similar to GetStoragePartitionConfigForSite(), but assumes it should
+  // parse |site| as if it were not in the default StoragePartition.
+  //
+  // If the embedder modifies the configuration of |site| so that it no
+  // longer has a non-default config there is a race where
+  // GetStoragePartitionConfigForSite() will no longer return the isolated
+  // configuration, but the embedder still needs to invoke cleanup code
+  // (such as data deleters) need to access the previous configuration.

[Charlie Reis, 2012/11/16 01:45:10]

nit: that need

[awong, 2012/11/16 02:56:10]

Function removed.

+  //
+  // This function is exposed for use by cleanup code.  This is needed because
+  // |site| has insufficient information to know whether or not it was
+  // part of the default StoragePartition.
+  virtual void ParseNonDefaultStoragePartitionConfig(

[Charlie Reis, 2012/11/16 01:45:10]

This is too complex to expose as its own function in the public API.  It's very
hard to understand how these two functions differ.

Another proposal: add something like a |might_be_default| parameter to
GetStoragePartitionConfigForSite.  If it's true, we behave as before.  If it's
false, we behave like your ParseNonDefaultStoragePartitionConfig.  It's clearer
to understand how it affects the outcome, and it seems to fit into your code
without too much effort.  Thoughts?

[awong, 2012/11/16 02:56:10]

Went with your solution.

+      const GURL& site,
+      std::string* partition_domain,
+      std::string* partition_name,
+      bool* in_memory);
+
   // Create and return a new quota permission context.
   virtual QuotaPermissionContext* CreateQuotaPermissionContext();
 
   // Open the given file in the desktop's default manner.
   virtual void OpenItem(const FilePath& path) {}
 
   // Show the given file in a file manager. If possible, select the file.
   virtual void ShowItemInFolder(const FilePath& path) {}
 
   // Informs the embedder that a certificate error has occured.  If
@@ skipping 173 matching lines @@
   // This is called on a worker thread.
   virtual
       crypto::CryptoModuleBlockingPasswordDelegate* GetCryptoPasswordDelegate(
           const GURL& url);
 #endif
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_