src/spaces.cc - Issue 11362246: Implement progress bar for large objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/spaces.cc

Issue 11362246: Implement progress bar for large objects. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed more comments. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/spaces.cc

diff --git a/src/spaces.cc b/src/spaces.cc

index 583b2ca5124982cda6302c4b6b62213b34c2752a..0ac23d279db6d5c13e3d9b0b67206cdd7f983ce0 100644

--- a/src/spaces.cc

+++ b/src/spaces.cc

@@ -448,6 +448,7 @@ MemoryChunk* MemoryChunk::Initialize(Heap* heap,

chunk->slots_buffer_ = NULL;

chunk->skip_list_ = NULL;

chunk->write_barrier_counter_ = kWriteBarrierCounterGranularity;

+ chunk->progress_bar_ = 0;

chunk->high_water_mark_ = static_cast<int>(area_start - base);

chunk->ResetLiveBytes();

Bitmap::Clear(chunk);

@@ -2784,7 +2785,8 @@ void LargeObjectSpace::FreeUnmarkedObjects() {

MarkBit mark_bit = Marking::MarkBitFrom(object);

if (mark_bit.Get()) {

mark_bit.Clear();

- MemoryChunk::IncrementLiveBytesFromGC(object->address(), -object->Size());

+ Page::FromAddress(object->address())->ResetProgressBar();

+ Page::FromAddress(object->address())->ResetLiveBytes();

previous = current;

current = current->next_page();

} else {

« no previous file with comments | « src/spaces.h ('k') | no next file » | no next file with comments »