reland of https://codereview.chromium.org/11364053/ w/o removing the per-rootwindow stacking client

reland of https://codereview.chromium.org/11364053/

Two changes from that CL:
- Don't remove per-RootWindow StackingClient (erg thought he probably needed it; if not I can remove it later in a separate CL)
- Fix initialization in Shell::PlatformInitialize (wasn't initializing correctly in the CrOS case), diff between ps1 and ps2 in content/shell/shell_aura.cc

TBR=ben@chromium.org
BUG=128578
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=167431

[Ben Goodger (Google), 2012-11-13 20:33:53]

i tried to say lgtm before but rietveld done gone broked itself. so lgtm.

-Ben


On Mon, Nov 12, 2012 at 9:03 PM, <scottmg@chromium.org> wrote:

> Reviewers: Ben Goodger (Google), Elliot Glaysher,
>
> Description:
> reland of
https://codereview.chromium.**org/11364053/<https://codereview.chromium.org/1...
>
> Two changes from that CL:
> - Don't remove per-RootWindow StackingClient (erg thought he probably
> needed it;
> if not I can remove it later in a separate CL)
> - Fix initialization in Shell::PlatformInitialize (wasn't initializing
> correctly
> in the CrOS case), diff between ps1 and ps2 in content/shell/shell_aura.cc
>
>
> BUG=128578
>
>
> Please review this at
http://codereview.chromium.**org/11362216/<http://codereview.chromium.org/113...
>
> SVN Base:
http://git.chromium.org/git/**chromium.git@trunk<http://git.chromium.org/git/...
>
> Affected files:
>   M ash/shell.h
>   M ash/shell.cc
>   M ash/shell/shell_delegate_impl.**h
>   M ash/shell/shell_delegate_impl.**cc
>   M ash/shell_delegate.h
>   M ash/test/test_shell_delegate.h
>   M ash/test/test_shell_delegate.**cc
>   M ash/wm/stacking_controller.h
>   M ash/wm/stacking_controller.cc
>   M chrome/browser/prerender/**prerender_manager.cc
>   M chrome/browser/prerender/**prerender_unittest.cc
>   M chrome/browser/ui/ash/chrome_**shell_delegate.h
>   M chrome/browser/ui/ash/chrome_**shell_delegate.cc
>   M chrome/browser/ui/aura/chrome_**browser_main_extra_parts_aura.**h
>   M chrome/browser/ui/aura/chrome_**browser_main_extra_parts_aura.**cc
>   A chrome/browser/ui/aura/**stacking_client_aura.h
>   A chrome/browser/ui/aura/**stacking_client_aura.cc
>   M chrome/browser/ui/browser_**commands.cc
>   M chrome/browser/ui/browser_**tabstrip.cc
>   M chrome/browser/ui/views/frame/**browser_frame.cc
>   M chrome/browser/ui/views/**omnibox/omnibox_popup_**contents_view.cc
>   M chrome/browser/ui/views/**status_bubble_views.cc
>   M chrome/chrome_browser_ui.gypi
>   M content/browser/renderer_host/**render_widget_host_view_aura.**cc
>   M content/shell/shell_aura.cc
>   M content/shell/shell_stacking_**client_ash.h
>   M content/shell/shell_stacking_**client_ash.cc
>   M ui/aura/client/stacking_**client.h
>   M ui/aura/demo/demo_main.cc
>   M ui/aura/desktop/desktop_**stacking_client.h
>   M ui/aura/desktop/desktop_**stacking_client.cc
>   M ui/aura/test/test_stacking_**client.h
>   M ui/aura/test/test_stacking_**client.cc
>   M ui/aura/window.cc
>   M ui/views/examples/content_**client/examples_browser_main_**parts.cc
>   M ui/views/widget/desktop_**native_widget_aura.cc
>   M ui/views/widget/native_widget_**aura.cc
>   M ui/views/widget/widget.h
>   M ui/views/widget/widget.cc
>
>
>

[scottmg, 2012-11-13 20:38:35]

Had to revert it again, you snuck some renames in there just before I
landed. 3rd time's the charm! http://codereview.chromium.org/11377140/


On Tue, Nov 13, 2012 at 12:33 PM, Ben Goodger (Google) <ben@chromium.org>wrote:

> i tried to say lgtm before but rietveld done gone broked itself. so lgtm.
>
> -Ben
>
>
> On Mon, Nov 12, 2012 at 9:03 PM, <scottmg@chromium.org> wrote:
>
>> Reviewers: Ben Goodger (Google), Elliot Glaysher,
>>
>> Description:
>> reland of
https://codereview.chromium.**org/11364053/<https://codereview.chromium.org/1...
>>
>> Two changes from that CL:
>> - Don't remove per-RootWindow StackingClient (erg thought he probably
>> needed it;
>> if not I can remove it later in a separate CL)
>> - Fix initialization in Shell::PlatformInitialize (wasn't initializing
>> correctly
>> in the CrOS case), diff between ps1 and ps2 in content/shell/shell_aura.cc
>>
>>
>> BUG=128578
>>
>>
>> Please review this at
http://codereview.chromium.**org/11362216/<http://codereview.chromium.org/113...
>>
>> SVN Base:
http://git.chromium.org/git/**chromium.git@trunk<http://git.chromium.org/git/...
>>
>> Affected files:
>>   M ash/shell.h
>>   M ash/shell.cc
>>   M ash/shell/shell_delegate_impl.**h
>>   M ash/shell/shell_delegate_impl.**cc
>>   M ash/shell_delegate.h
>>   M ash/test/test_shell_delegate.h
>>   M ash/test/test_shell_delegate.**cc
>>   M ash/wm/stacking_controller.h
>>   M ash/wm/stacking_controller.cc
>>   M chrome/browser/prerender/**prerender_manager.cc
>>   M chrome/browser/prerender/**prerender_unittest.cc
>>   M chrome/browser/ui/ash/chrome_**shell_delegate.h
>>   M chrome/browser/ui/ash/chrome_**shell_delegate.cc
>>   M chrome/browser/ui/aura/chrome_**browser_main_extra_parts_aura.**h
>>   M chrome/browser/ui/aura/chrome_**browser_main_extra_parts_aura.**cc
>>   A chrome/browser/ui/aura/**stacking_client_aura.h
>>   A chrome/browser/ui/aura/**stacking_client_aura.cc
>>   M chrome/browser/ui/browser_**commands.cc
>>   M chrome/browser/ui/browser_**tabstrip.cc
>>   M chrome/browser/ui/views/frame/**browser_frame.cc
>>   M chrome/browser/ui/views/**omnibox/omnibox_popup_**contents_view.cc
>>   M chrome/browser/ui/views/**status_bubble_views.cc
>>   M chrome/chrome_browser_ui.gypi
>>   M content/browser/renderer_host/**render_widget_host_view_aura.**cc
>>   M content/shell/shell_aura.cc
>>   M content/shell/shell_stacking_**client_ash.h
>>   M content/shell/shell_stacking_**client_ash.cc
>>   M ui/aura/client/stacking_**client.h
>>   M ui/aura/demo/demo_main.cc
>>   M ui/aura/desktop/desktop_**stacking_client.h
>>   M ui/aura/desktop/desktop_**stacking_client.cc
>>   M ui/aura/test/test_stacking_**client.h
>>   M ui/aura/test/test_stacking_**client.cc
>>   M ui/aura/window.cc
>>   M ui/views/examples/content_**client/examples_browser_main_**parts.cc
>>   M ui/views/widget/desktop_**native_widget_aura.cc
>>   M ui/views/widget/native_widget_**aura.cc
>>   M ui/views/widget/widget.h
>>   M ui/views/widget/widget.cc
>>
>>
>>
>