runtime/vm/flow_graph_optimizer.cc - Issue 11362210: Restrict immediate operands to smi where only smis are supported.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 11362210: Restrict immediate operands to smi where only smis are supported. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_optimizer.cc

===================================================================

--- runtime/vm/flow_graph_optimizer.cc (revision 14796)

+++ runtime/vm/flow_graph_optimizer.cc (working copy)

@@ -32,8 +32,7 @@

"Eliminate redundant bounds checks.");

DEFINE_FLAG(int, max_polymorphic_checks, 4,

"Maximum number of polymorphic check, otherwise it is megamorphic.");

-DEFINE_FLAG(bool, remove_redundant_phis, false,

- "Remove redundant phis (disabled as causes incorrect code).");

+DEFINE_FLAG(bool, remove_redundant_phis, true, "Remove redundant phis.");

void FlowGraphOptimizer::ApplyICData() {

« no previous file with comments | « runtime/vm/disassembler_x64.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | runtime/vm/intermediate_language_ia32.cc » ('J')