Restrict immediate operands to smi where only smis are supported.

runtime/vm/assembler_x64_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"
 #if defined(TARGET_ARCH_X64)
 
 #include "vm/assembler.h"
 #include "vm/os.h"
 #include "vm/unit_test.h"
@@ skipping 328 matching lines @@
 }
 
 
 ASSEMBLER_TEST_RUN(SignedMultiply, entry) {
   typedef int (*SignedMultiply)();
   EXPECT_EQ(8000, reinterpret_cast<SignedMultiply>(entry)());
 }
 
 
 ASSEMBLER_TEST_GENERATE(SignedMultiply64, assembler) {
+  __ pushq(R15);  // Callee saved.
   __ movq(RAX, Immediate(2));
   __ movq(RCX, Immediate(4));
   __ imulq(RAX, RCX);
+
   __ movq(R8, Immediate(2));
   __ movq(R9, Immediate(4));
   __ pushq(R9);
   __ imulq(R8, Address(RSP, 0));
   __ popq(R9);
   __ addq(RAX, R8);
+
+  __ movq(R10, Immediate(2));
+  __ movq(R11, Immediate(4));
+  __ imulq(R10, R11);
+  __ addq(RAX, R10);
+
+  __ movq(R15, Immediate(2));
+  __ imulq(R15, Immediate(4));
+  __ addq(RAX, R15);
+  __ popq(R15);
   __ ret();
 }
 
 
 ASSEMBLER_TEST_RUN(SignedMultiply64, entry) {
   typedef int64_t (*SignedMultiply64)();
-  EXPECT_EQ(16, reinterpret_cast<SignedMultiply64>(entry)());
+  EXPECT_EQ(32, reinterpret_cast<SignedMultiply64>(entry)());
 }
 
 
 static const int64_t kLargeConstant = 0x1234567887654321;
 static const int64_t kAnotherLargeConstant = 987654321987654321LL;
 static const int64_t kProductLargeConstants = 0x5bbb29a7f52fbbd1;
 
 
 ASSEMBLER_TEST_GENERATE(SignedMultiplyLong, assembler) {
+  Label done;
   __ movq(RAX, Immediate(kLargeConstant));
   __ movq(RCX, Immediate(kAnotherLargeConstant));
   __ imulq(RAX, RCX);
+  __ imulq(RCX, Immediate(kLargeConstant));
+  __ cmpq(RAX, RCX);
+  __ j(EQUAL, &done);
+  __ int3();
+  __ Bind(&done);
   __ ret();
 }
 
 
 ASSEMBLER_TEST_RUN(SignedMultiplyLong, entry) {
   typedef int64_t (*SignedMultiplyLong)();
   EXPECT_EQ(kProductLargeConstants,
             reinterpret_cast<SignedMultiplyLong>(entry)());
 }
 
@@ skipping 23 matching lines @@
   __ ret();
 }
 
 
 ASSEMBLER_TEST_RUN(SignedMultiply1, entry) {
   typedef int (*SignedMultiply1)();
   EXPECT_EQ(8000, reinterpret_cast<SignedMultiply1>(entry)());
 }
 
 
+ASSEMBLER_TEST_GENERATE(SignedMultiply2, assembler) {
+  __ pushq(R15);  // Callee saved.
+  __ movl(R15, Immediate(2));
+  __ imull(R15, Immediate(1000));
+  __ movl(RAX, R15);
+  __ popq(R15);
+  __ ret();
+}
+
+
+ASSEMBLER_TEST_RUN(SignedMultiply2, entry) {
+  typedef int (*SignedMultiply2)();
+  EXPECT_EQ(2000, reinterpret_cast<SignedMultiply2>(entry)());
+}
+
+
 ASSEMBLER_TEST_GENERATE(SignedDivide, assembler) {
   __ movl(RAX, Immediate(-87));
   __ movl(RDX, Immediate(123));
   __ cdq();
   __ movl(RCX, Immediate(42));
   __ idivl(RCX);
   __ ret();
 }
 
 
@@ skipping 337 matching lines @@
   EXPECT_EQ(0, reinterpret_cast<LogicalOpsCode>(entry)());
 }
 
 
 ASSEMBLER_TEST_GENERATE(LogicalOps64, assembler) {
   Label donetest1;
   __ movq(RAX, Immediate(4));
   __ andq(RAX, Immediate(2));
   __ cmpq(RAX, Immediate(0));
   __ j(EQUAL, &donetest1);
-  // Be sure to skip this crashing code.
-  __ movq(RAX, Immediate(0));
-  __ movq(Address(RAX, 0), RAX);
+  __ int3();
   __ Bind(&donetest1);
 
   Label donetest2;
   __ movq(RCX, Immediate(4));
   __ pushq(RCX);
   __ andq(RCX, Address(RSP, 0));
   __ popq(RAX);
   __ cmpq(RCX, Immediate(0));
   __ j(NOT_EQUAL, &donetest2);
-  // Be sure to skip this crashing code.
-  __ movq(RAX, Immediate(0));
-  __ movq(Address(RAX, 0), RAX);
+  __ int3();
   __ Bind(&donetest2);
 
   Label donetest3;
   __ movq(RAX, Immediate(0));
   __ orq(RAX, Immediate(0));
   __ cmpq(RAX, Immediate(0));
   __ j(EQUAL, &donetest3);
-  // Be sure to skip this crashing code.
-  __ movq(RAX, Immediate(0));
-  __ movq(Address(RAX, 0), RAX);
+  __ int3();
   __ Bind(&donetest3);
 
   Label donetest4;
   __ movq(RAX, Immediate(4));
   __ orq(RAX, Immediate(0));
   __ cmpq(RAX, Immediate(0));
   __ j(NOT_EQUAL, &donetest4);
-  // Be sure to skip this crashing code.
-  __ movq(RAX, Immediate(0));
-  __ movq(Address(RAX, 0), RAX);
+  __ int3();
   __ Bind(&donetest4);
 
   Label donetest5;
   __ pushq(RAX);
   __ movq(RAX, Immediate(0xff));
   __ movq(Address(RSP, 0), RAX);
   __ cmpq(Address(RSP, 0), Immediate(0xff));
   __ j(EQUAL, &donetest5);
-  // Be sure to skip this crashing code.
-  __ movq(RAX, Immediate(0));
-  __ movq(Address(RAX, 0), RAX);
+  __ int3();
   __ Bind(&donetest5);
   __ popq(RAX);
 
   Label donetest6;
   __ movq(RAX, Immediate(1));
   __ shlq(RAX, Immediate(3));
   __ cmpq(RAX, Immediate(8));
   __ j(EQUAL, &donetest6);
-  // Be sure to skip this crashing code.
-  __ movq(RAX, Immediate(0));
-  __ movq(Address(RAX, 0), RAX);
+  __ int3();
   __ Bind(&donetest6);
 
   Label donetest7;
   __ movq(RAX, Immediate(2));
   __ shrq(RAX, Immediate(1));
   __ cmpq(RAX, Immediate(1));
   __ j(EQUAL, &donetest7);
-  // Be sure to skip this crashing code.
-  __ movq(RAX, Immediate(0));
-  __ movq(Address(RAX, 0), RAX);
+  __ int3();
   __ Bind(&donetest7);
 
   Label donetest8;
   __ movq(RAX, Immediate(8));
   __ shrq(RAX, Immediate(3));
   __ cmpq(RAX, Immediate(1));
   __ j(EQUAL, &donetest8);
-  // Be sure to skip this crashing code.
-  __ movq(RAX, Immediate(0));
-  __ movq(Address(RAX, 0), RAX);
+  __ int3();
   __ Bind(&donetest8);
 
   Label donetest9;
   __ movq(RAX, Immediate(1));
   __ movq(RCX, Immediate(3));
   __ shlq(RAX, RCX);
   __ cmpq(RAX, Immediate(8));
   __ j(EQUAL, &donetest9);
-  // Be sure to skip this crashing code.
-  __ movq(RAX, Immediate(0));
-  __ movq(Address(RAX, 0), RAX);
+  __ int3();
   __ Bind(&donetest9);
 
   Label donetest10;
   __ movq(RAX, Immediate(8));
   __ movq(RCX, Immediate(3));
   __ shrq(RAX, RCX);
   __ cmpq(RAX, Immediate(1));
   __ j(EQUAL, &donetest10);
-  // Be sure to skip this crashing code.
-  __ movq(RAX, Immediate(0));
-  __ movq(Address(RAX, 0), RAX);
+  __ int3();
   __ Bind(&donetest10);
 
   Label donetest6a;
   __ movq(RAX, Immediate(1));
   __ shlq(RAX, Immediate(3));
   __ cmpq(RAX, Immediate(8));
   __ j(EQUAL, &donetest6a);
   // Be sure to skip this crashing code.
   __ movq(RAX, Immediate(0));
   __ movq(Address(RAX, 0), RAX);
   __ Bind(&donetest6a);
 
   Label donetest7a;
   __ movq(RAX, Immediate(2));
   __ shrq(RAX, Immediate(1));
   __ cmpq(RAX, Immediate(1));
   __ j(EQUAL, &donetest7a);
-  // Be sure to skip this crashing code.
-  __ movq(RAX, Immediate(0));
-  __ movq(Address(RAX, 0), RAX);
+  __ int3();
   __ Bind(&donetest7a);
 
   Label donetest8a;
   __ movq(RAX, Immediate(8));
   __ shrq(RAX, Immediate(3));
   __ cmpq(RAX, Immediate(1));
   __ j(EQUAL, &donetest8a);
-  // Be sure to skip this crashing code.
-  __ movq(RAX, Immediate(0));
-  __ movq(Address(RAX, 0), RAX);
+  __ int3();
   __ Bind(&donetest8a);
 
   Label donetest9a;
   __ movq(RAX, Immediate(1));
   __ movq(RCX, Immediate(3));
   __ shlq(RAX, RCX);
   __ cmpq(RAX, Immediate(8));
   __ j(EQUAL, &donetest9a);
-  // Be sure to skip this crashing code.
-  __ movq(RAX, Immediate(0));
-  __ movq(Address(RAX, 0), RAX);
+  __ int3();
   __ Bind(&donetest9a);
 
   Label donetest10a;
   __ movq(RAX, Immediate(8));
   __ movq(RCX, Immediate(3));
   __ shrq(RAX, RCX);
   __ cmpq(RAX, Immediate(1));
   __ j(EQUAL, &donetest10a);
-  // Be sure to skip this crashing code.
-  __ movq(RAX, Immediate(0));
-  __ movq(Address(RAX, 0), RAX);
+  __ int3();
   __ Bind(&donetest10a);
 
   Label donetest11a;
   __ movq(RAX, Immediate(1));
   __ shlq(RAX, Immediate(31));
   __ shrq(RAX, Immediate(3));
   __ cmpq(RAX, Immediate(0x10000000));
   __ j(EQUAL, &donetest11a);
-  // Be sure to skip this crashing code.
-  __ movq(RAX, Immediate(0));
-  __ movq(Address(RAX, 0), RAX);
+  __ int3();
   __ Bind(&donetest11a);
 
   Label donetest12a;
   __ movq(RAX, Immediate(1));
   __ shlq(RAX, Immediate(63));
   __ sarq(RAX, Immediate(3));
   __ cmpq(RAX, Immediate(0xf000000000000000));
   __ j(EQUAL, &donetest12a);
-  // Be sure to skip this crashing code.
-  __ movq(RAX, Immediate(0));
-  __ movq(Address(RAX, 0), RAX);
+  __ int3();
   __ Bind(&donetest12a);
 
   Label donetest13a;
   __ movq(RAX, Immediate(1));
   __ movq(RCX, Immediate(3));
   __ shlq(RAX, Immediate(63));
   __ sarq(RAX, RCX);
   __ cmpq(RAX, Immediate(0xf000000000000000));
   __ j(EQUAL, &donetest13a);
-  // Be sure to skip this crashing code.
-  __ movq(RAX, Immediate(0));
-  __ movq(Address(RAX, 0), RAX);
+  __ int3();
   __ Bind(&donetest13a);
 
+  Label donetest14, donetest15;
+  __ pushq(R15);  // Callee saved.
+  __ movq(R15, Immediate(0xf000000000000001));
+  __ andq(R15, Immediate(-1));
+  __ andq(R15, Immediate(0x8000000000000001));
+  __ orq(R15, Immediate(2));
+  __ orq(R15, Immediate(0xf800000000000000));
+  __ xorq(R15, Immediate(1));
+  __ xorq(R15, Immediate(0x0800000000000000));
+  __ cmpq(R15, Immediate(0xf000000000000002));
+  __ j(EQUAL, &donetest14);
+  __ int3();
+  __ Bind(&donetest14);
+  __ andq(R15, Immediate(2));
+  __ cmpq(R15, Immediate(2));
+  __ j(EQUAL, &donetest15);
+  __ int3();
+  __ Bind(&donetest15);
+  __ popq(R15);  // Callee saved.
+
   __ movq(RAX, Immediate(0));
   __ ret();
 }
 
 
 ASSEMBLER_TEST_RUN(LogicalOps64, entry) {
   typedef int (*LogicalOpsCode)();
   EXPECT_EQ(0, reinterpret_cast<LogicalOpsCode>(entry)());
 }
 
@@ skipping 752 matching lines @@
   EXPECT_EQ(0, res);
   res = reinterpret_cast<ExtractSignBits>(entry)(-1.0);
   EXPECT_EQ(1, res);
   res = reinterpret_cast<ExtractSignBits>(entry)(-0.0);
   EXPECT_EQ(1, res);
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_X64