Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1638)

Unified Diff: android_webview/browser/aw_content_browser_client.cc

Issue 11362183: [Android WebView] AwContentsClient.shouldCreateWindow callback part 1. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/aw_content_browser_client.cc
diff --git a/android_webview/browser/aw_content_browser_client.cc b/android_webview/browser/aw_content_browser_client.cc
index 7caa743bc123acbac72edd94ddbdbafc7b49881b..9e1da9e082e0c1256f9b2f2fc8bc964923e35ca0 100644
--- a/android_webview/browser/aw_content_browser_client.cc
+++ b/android_webview/browser/aw_content_browser_client.cc
@@ -237,10 +237,14 @@ bool AwContentBrowserClient::CanCreateWindow(
content::ResourceContext* context,
int render_process_id,
bool* no_javascript_access) {
- // TODO(boliu): Implement this to power SupportMultipleWindow.
- NOTIMPLEMENTED();
- *no_javascript_access = false;
- return false;
+ // We unconditionally allow popup windows at this stage and will give
+ // the embedder the opporunity to handle displaying of the popup in
+ // WebContentsDelegate::AddContents (via the
+ // AwContentsClient.onCreateWindow callback).
+ if (no_javascript_access) {
+ *no_javascript_access = false;
+ }
+ return true;
}
std::string AwContentBrowserClient::GetWorkerProcessTitle(const GURL& url,

Powered by Google App Engine
This is Rietveld 408576698