Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11362174: Update NSS to NSS 3.14 pre-release snapshot 2012-06-28 01:00:00 PDT. (Closed)

Created:
8 years, 1 month ago by wtc
Modified:
8 years, 1 month ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews
Visibility:
Public.

Description

Update NSS to NSS 3.14 pre-release snapshot 2012-06-28 01:00:00 PDT. This snapshot contains the NSS patch for https://bugzilla.mozilla.org/show_bug.cgi?id=753116 (softoken needs to split out common components to util) was checked in, which we suspect may have caused the crash in bug 153281. TBR=rsleevi@chromium.org BUG=151692 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=166832

Patch Set 1 #

Patch Set 2 : Update the snapshot timestamp in README.chromium #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1252 lines, -3933 lines) Patch
M README.chromium View 1 3 chunks +9 lines, -3 lines 0 comments Download
A + mozilla/security/nss/lib/cryptohi/sechash.h View 1 chunk +1 line, -1 line 0 comments Download
D mozilla/security/nss/lib/freebl/hasht.h View 1 chunk +0 lines, -72 lines 0 comments Download
M mozilla/security/nss/lib/freebl/rawhash.c View 1 chunk +1 line, -1 line 0 comments Download
D mozilla/security/nss/lib/freebl/sechash.h View 1 chunk +0 lines, -58 lines 0 comments Download
M mozilla/security/nss/lib/freebl/tlsprfalg.c View 1 chunk +3 lines, -3 lines 0 comments Download
M mozilla/security/nss/lib/nss/nssinit.c View 3 chunks +11 lines, -10 lines 0 comments Download
M mozilla/security/nss/lib/pk11wrap/pk11load.c View 1 chunk +1 line, -0 lines 0 comments Download
M mozilla/security/nss/lib/pk11wrap/pk11pars.c View 23 chunks +57 lines, -136 lines 0 comments Download
M mozilla/security/nss/lib/pk11wrap/pk11slot.c View 1 chunk +1 line, -0 lines 0 comments Download
M mozilla/security/nss/lib/pk11wrap/pk11util.c View 2 chunks +2 lines, -1 line 0 comments Download
M mozilla/security/nss/lib/pk11wrap/secmodi.h View 1 chunk +0 lines, -2 lines 0 comments Download
A + mozilla/security/nss/lib/pk11wrap/secmodt.h View 3 chunks +2 lines, -29 lines 1 comment Download
M mozilla/security/nss/lib/pk11wrap/secmodti.h View 1 chunk +0 lines, -1 line 0 comments Download
D mozilla/security/nss/lib/softoken/pk11init.h View 1 chunk +0 lines, -23 lines 0 comments Download
D mozilla/security/nss/lib/softoken/pk11pars.h View 1 chunk +0 lines, -841 lines 0 comments Download
M mozilla/security/nss/lib/softoken/pkcs11.c View 3 chunks +72 lines, -26 lines 0 comments Download
M mozilla/security/nss/lib/softoken/pkcs11c.c View 1 chunk +0 lines, -1 line 0 comments Download
M mozilla/security/nss/lib/softoken/pkcs11i.h View 4 chunks +9 lines, -6 lines 0 comments Download
M mozilla/security/nss/lib/softoken/rsawrapr.c View 1 chunk +1 line, -2 lines 0 comments Download
M mozilla/security/nss/lib/softoken/sdb.h View 1 chunk +1 line, -1 line 0 comments Download
M mozilla/security/nss/lib/softoken/sdb.c View 1 chunk +1 line, -1 line 0 comments Download
D mozilla/security/nss/lib/softoken/secmodt.h View 1 chunk +0 lines, -475 lines 0 comments Download
M mozilla/security/nss/lib/softoken/sftkdb.h View 1 chunk +0 lines, -15 lines 0 comments Download
M mozilla/security/nss/lib/softoken/sftkdb.c View 3 chunks +7 lines, -8 lines 0 comments Download
M mozilla/security/nss/lib/softoken/sftkdbt.h View 1 chunk +0 lines, -7 lines 0 comments Download
D mozilla/security/nss/lib/softoken/sftkmod.c View 1 chunk +0 lines, -731 lines 0 comments Download
M mozilla/security/nss/lib/softoken/sftkpars.c View 7 chunks +62 lines, -438 lines 0 comments Download
M mozilla/security/nss/lib/softoken/sftkpwd.c View 1 chunk +1 line, -3 lines 0 comments Download
A + mozilla/security/nss/lib/util/hasht.h View 2 chunks +1 line, -12 lines 0 comments Download
M mozilla/security/nss/lib/util/secerr.h View 1 chunk +2 lines, -0 lines 0 comments Download
A + mozilla/security/nss/lib/util/utilmod.c View 27 chunks +119 lines, -159 lines 0 comments Download
A + mozilla/security/nss/lib/util/utilmodt.h View 2 chunks +8 lines, -443 lines 0 comments Download
A mozilla/security/nss/lib/util/utilpars.h View 1 chunk +52 lines, -0 lines 0 comments Download
A + mozilla/security/nss/lib/util/utilpars.c View 21 chunks +682 lines, -414 lines 0 comments Download
A mozilla/security/nss/lib/util/utilparst.h View 1 chunk +76 lines, -0 lines 0 comments Download
M nss.gyp View 8 chunks +8 lines, -6 lines 0 comments Download
A patches/nss-error-collision.patch View 1 chunk +21 lines, -0 lines 0 comments Download
A patches/nss-utilpars.patch View 1 chunk +38 lines, -0 lines 0 comments Download
M scripts/nss-checkout.sh View 4 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
wtc
8 years, 1 month ago (2012-11-09 00:50:22 UTC) #1
Ryan Sleevi
rubberstamp lgtm
8 years, 1 month ago (2012-11-12 17:23:40 UTC) #2
wtc
8 years, 1 month ago (2012-11-24 00:24:37 UTC) #3
Message was sent while issue was closed. 
https://codereview.chromium.org/11362174/diff/5004/mozilla/security/nss/lib/p...
File mozilla/security/nss/lib/pk11wrap/secmodt.h (right):

https://codereview.chromium.org/11362174/diff/5004/mozilla/security/nss/lib/p...
mozilla/security/nss/lib/pk11wrap/secmodt.h:33: typedef struct
NSSUTILPreSlotInfoStr PK11PreSlotInfo; /* defined in secmodti.h */

This comment needs to be updated. struct NSSUTILPreSlotInfoStr
is defined in utilparst.h.

Powered by Google App Engine
This is Rietveld 408576698