Issue 11362158: Reshuffle an if() condition to not depend on an uninitialized value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11362158: Reshuffle an if() condition to not depend on an uninitialized value. (Closed)

Created:
8 years, 1 month ago by eugenis

Modified:
8 years, 1 month ago

Reviewers:
Vyacheslav Egorov (Chromium), danno, Michael Starzinger

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Reshuffle an if() condition to not depend on an uninitialized value. Node::class_id_ contains garbage for newly allocated (FREE) nodes. This patch changes the code to first test the node state_, then (for non-FREE nodes), class_id_, and not the other way around. This does not affect the branch taken (i.e. the current code is correct), but makes Valgrind and MSan happy. Committed: https://code.google.com/p/v8/source/detail?r=12903

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/global-handles.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

eugenis

This is causing hard-to-debug issues with Valgrind in Chromium: http://code.google.com/p/chromium/issues/detail?id=102257

8 years, 1 month ago (2012-11-08 13:46:39 UTC) #2

eugenis

8 years, 1 month ago (2012-11-09 08:44:42 UTC) #4

On 2012/11/08 14:35:26, Michael Starzinger wrote:
> LGTM. I'll land this for you.

Thanks.

Expand Messages | Collapse Messages