IPC to generate mailbox names on the GPU process IO thread.

IPC to generate mailbox names on the GPU process IO thread.

This allows the browser and renderer processes to get new unique mailbox names without syncing with the GPU process main thread.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166351

[piman, 2012-11-02 01:18:14]

The overall approach looks great, but I would move GenerateMailboxNames onto
CommandBufferProxyImpl for consistency. WDYT?

LGTM otherwise.

https://codereview.chromium.org/11362053/diff/1/content/common/gpu/client/gpu...
File content/common/gpu/client/gpu_channel_host.cc (right):

https://codereview.chromium.org/11362053/diff/1/content/common/gpu/client/gpu...
content/common/gpu/client/gpu_channel_host.cc:245: bool
GpuChannelHost::GenerateMailboxNames(unsigned num,
nit: should we put this on CommandBufferProxyImpl, like other "looks like a GL
command but is implemented by an IPC" methods?

[apatrick_chromium, 2012-11-05 20:42:24]

There's no need for a command buffer to generate a mailbox names. How about
having GenerateMailboxNames on both GpuChannelHost and CommandBufferProxyImpl?
It might avoid awkward indirections.

[piman, 2012-11-06 23:54:34]

lgtm

[commit-bot: I haz the power, 2012-11-06 23:59:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/apatrick@chromium.org/11362053/8001

[commit-bot: I haz the power, 2012-11-07 00:24:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/apatrick@chromium.org/11362053/5004

[commit-bot: I haz the power, 2012-11-07 04:45:20]

Change committed as 166351