dart/tools/testing/run_selenium.py - Issue 11362036: Disable Firefox console logging as it appears to hang the browser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/tools/testing/run_selenium.py

Issue 11362036: Disable Firefox console logging as it appears to hang the browser. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: dart/tools/testing/run_selenium.py

diff --git a/dart/tools/testing/run_selenium.py b/dart/tools/testing/run_selenium.py

index e9e11193ddfd647580df49bde8a2cbbd122a059d..322f560617d00a66b8a171881c08e2ed8acb32ba 100755

--- a/dart/tools/testing/run_selenium.py

+++ b/dart/tools/testing/run_selenium.py

@@ -170,10 +170,8 @@ def start_browser(browser, executable_path, html_out):

profile.set_preference('dom.max_chrome_script_run_time', 0)

profile.set_preference('app.update.auto', True)

profile.set_preference('app.update.enabled', True)

- xpi = os.path.join(script_dir, 'extensions', 'firefox', 'ConsoleCollector.xpi')

- profile.add_extension(xpi);

return selenium.webdriver.Firefox(firefox_profile=profile)

- elif ((browser == 'ie9' or browser == 'ie10') and

+ elif ((browser == 'ie9' or browser == 'ie10') and

platform.system() == 'Windows'):

return selenium.webdriver.Ie()

elif browser == 'safari' and platform.system() == 'Darwin':

@@ -245,12 +243,6 @@ def report_results(mode, source, browser):

index += len('<body>')

end_index = source.find('</body')

print unicode(source[index : end_index]).encode("utf-8")

- if type(browser) is selenium.webdriver.firefox.webdriver.WebDriver:

- logs = browser.execute_script("return window.ConsoleCollector.read()");

- for msg in logs:

- print('%s:%s:%s:%s %s' %(

- msg['source'], msg['line'], msg['column'],

- msg['category'], msg['message']))

return 1

« no previous file with comments | « no previous file | no next file » | no next file with comments »