Add a menu item for configuring configurable providers.

Add a menu item for configuring configurable providers.

TEST=Tested manually with a fake provider extension.
BUG=474146
Committed: https://crrev.com/0e2e9f24ec13d090cec206cfbe415db8e8ce29b3
Cr-Commit-Position: refs/heads/master@{#329796}

[mtomasz, 2015-05-12 08:02:51]

mtomasz@chromium.org changed reviewers:
+ yawano@chromium.org

[mtomasz, 2015-05-12 08:03:15]

@yawano: PTAL. Thanks.

[yawano, 2015-05-12 08:37:45]

https://codereview.chromium.org/1136193002/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/foreground/js/file_manager_commands.js
(right):

https://codereview.chromium.org/1136193002/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/js/file_manager_commands.js:1336:
prototype: Object.create(Command.prototype),
To create a prototype chain, I think you need to set __proto__:
Command.prototype here.

[mtomasz, 2015-05-13 01:24:44]

https://codereview.chromium.org/1136193002/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/foreground/js/file_manager_commands.js
(right):

https://codereview.chromium.org/1136193002/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/js/file_manager_commands.js:1336:
prototype: Object.create(Command.prototype),
On 2015/05/12 08:37:45, yawano wrote:
> To create a prototype chain, I think you need to set __proto__:
> Command.prototype here.

Using __proto__ is discouraged per
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Obje...,
which suggests to use Object.create. However, my code was missing setting a
constructor, as in
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Obje....

After rethinking, I changed to simple __proto__: Command.prototype for
simplicity and consistency. We should consider migrating to Object.create some
day in all Files app code, though.

[yawano, 2015-05-13 02:26:49]

I see no change in file_manager_commands.js. Could you confirm that you uploaded
a correct patch set?

https://codereview.chromium.org/1136193002/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/foreground/js/file_manager_commands.js
(right):

https://codereview.chromium.org/1136193002/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/js/file_manager_commands.js:1336:
prototype: Object.create(Command.prototype),
I didn't know it. Thank you for the details! Yes, we should migrate from
__proto__ at some point.

[mtomasz, 2015-05-13 03:08:05]

On 2015/05/13 02:26:49, yawano wrote:
> I see no change in file_manager_commands.js. Could you confirm that you
uploaded
> a correct patch set?
> 
>
https://codereview.chromium.org/1136193002/diff/1/ui/file_manager/file_manage...
> File ui/file_manager/file_manager/foreground/js/file_manager_commands.js
> (right):
> 
>
https://codereview.chromium.org/1136193002/diff/1/ui/file_manager/file_manage...
> ui/file_manager/file_manager/foreground/js/file_manager_commands.js:1336:
> prototype: Object.create(Command.prototype),
> I didn't know it. Thank you for the details! Yes, we should migrate from
> __proto__ at some point.

Oops, done. PTAL!

[yawano, 2015-05-13 03:10:58]

lgtm. Thank you!

[mtomasz, 2015-05-13 03:13:53]

On 2015/05/13 03:10:58, yawano wrote:
> lgtm. Thank you!

Thanks!

[mtomasz, 2015-05-13 03:14:09]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2015-05-13 03:14:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1136193002/40001

[commit-bot: I haz the power, 2015-05-13 05:36:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-13 05:36:22]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mtomasz, 2015-05-14 03:35:12]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2015-05-14 03:35:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1136193002/40001

[commit-bot: I haz the power, 2015-05-14 04:04:35]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-05-14 04:05:31]

Patchset 3 (id:??) landed as
https://crrev.com/0e2e9f24ec13d090cec206cfbe415db8e8ce29b3
Cr-Commit-Position: refs/heads/master@{#329796}