Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1136143005: Send a Blur notification to the renderer if we receive a mouse exit for a window outside a popup. (Closed)

Created:
5 years, 7 months ago by ananta
Modified:
5 years, 7 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Send a Blur notification to the renderer if we receive a mouse exit for a window outside a popup. Blink maintains state for popups whether they are hidden shown etc. So when a popup is shown and an action causes the popup to be hidden then blink changes the state to hidden. If an action causes the popup to be closed on the browser without notifying blink that the popup is going away due to focus being lost on the parent view, then blink assumes that the popup is still visible. As a result clicking again on a select box would just hide the popup as blink thinks the popup is visible. This bug is only triggered in corner cases like ASH where you have one root window parenting everything else. On regular desktop environments clicking outside the browser window while the popup is open would cause activation changes to occur which would ensure that the Blur notification goes through to the browser. The other change is a simple fix in delegate_execute which caused it to crash in debug mode on a multi dll build. Crash occurred because we were looking for version information in base.dll while launching the crash server. BUG=482937 Committed: https://crrev.com/56fb0ec2da13e47e65d1ef8e07dee1a9a37fde70 Cr-Commit-Position: refs/heads/master@{#329563}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M win8/delegate_execute/crash_server_init.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
ananta
5 years, 7 months ago (2015-05-13 00:52:25 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm
5 years, 7 months ago (2015-05-13 01:36:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136143005/1
5 years, 7 months ago (2015-05-13 01:36:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-13 01:51:29 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 01:53:22 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/56fb0ec2da13e47e65d1ef8e07dee1a9a37fde70
Cr-Commit-Position: refs/heads/master@{#329563}

Powered by Google App Engine
This is Rietveld 408576698