Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: runtime/vm/gc_sweeper.cc

Issue 1136143003: Remove fake isolate from concurrent sweeper and extend lifetime of VM threads. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/isolate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/gc_sweeper.cc
===================================================================
--- runtime/vm/gc_sweeper.cc (revision 45808)
+++ runtime/vm/gc_sweeper.cc (working copy)
@@ -113,7 +113,7 @@
}
virtual void Run() {
- Thread::EnterIsolate(task_isolate_);
+ Thread::EnterIsolateAsHelper(task_isolate_);
GCSweeper sweeper;
HeapPage* page = first_;
@@ -143,8 +143,7 @@
old_space_->set_tasks(old_space_->tasks() - 1);
ml.Notify();
}
- Thread::ExitIsolate();
- delete task_isolate_;
+ Thread::ExitIsolateAsHelper();
}
private:
@@ -161,7 +160,7 @@
HeapPage* last,
FreeList* freelist) {
SweeperTask* task =
- new SweeperTask(isolate->ShallowCopy(),
+ new SweeperTask(isolate,
isolate->heap()->old_space(),
first, last,
freelist);
« no previous file with comments | « no previous file | runtime/vm/isolate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698