Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 1136133003: Update the visuals of about:flags "Relaunch Now" button. (Closed)

Created:
5 years, 7 months ago by Ted C
Modified:
5 years, 7 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, arv+watch_chromium.org, newt (away)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update the visuals of about:flags "Relaunch Now" button. Make it visually aligned with other buttons from chrome error pages. Make it easier to see by giving it more contrast. Update the formatting to remove an explicit height being set to give a nicer look on various orientations of devices. BUG=486816 Committed: https://crrev.com/bca23e588da39bd335338f3fdebe470eacd77e2a Cr-Commit-Position: refs/heads/master@{#329271}

Patch Set 1 #

Total comments: 2

Patch Set 2 : address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -5 lines) Patch
M chrome/browser/resources/flags.css View 1 3 chunks +21 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Ted C
PTAL
5 years, 7 months ago (2015-05-11 18:28:22 UTC) #2
Dan Beam
i think looks confusingly similar to infobars on mobile, but fellow co-workers polled (estade@) didn't ...
5 years, 7 months ago (2015-05-11 21:32:31 UTC) #3
Dan Beam
On 2015/05/11 21:32:31, Dan Beam wrote: > i think looks confusingly similar to infobars on ...
5 years, 7 months ago (2015-05-11 21:32:51 UTC) #4
Ted C
I agree they do look like infobars, but we've trained our users to look at ...
5 years, 7 months ago (2015-05-11 22:19:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136133003/20001
5 years, 7 months ago (2015-05-11 22:21:41 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-11 23:42:29 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 23:44:18 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bca23e588da39bd335338f3fdebe470eacd77e2a
Cr-Commit-Position: refs/heads/master@{#329271}

Powered by Google App Engine
This is Rietveld 408576698