Issue 1136133002: Re-instate: Implement lossy pref behavior for JsonPrefStore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1136133002: Re-instate: Implement lossy pref behavior for JsonPrefStore. (Closed)

Created:
5 years, 7 months ago by Dan Beam

Modified:
5 years, 7 months ago

Reviewers:
benwells, raymes, robert.bradford

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Re-instate: Implement lossy pref behavior for JsonPrefStore. https://codereview.chromium.org/1127963002/ This reverts commit 74bb4ded177e5058878ae3d0e510ef83595f8f3a. It also adds a valgrind unitialized memory fix by initializing a bool member to false (which is what another constructor does, so I'm pretty sure it's right). TBR=raymes@chromium.org,benwells@chromium.org,robert.bradford@intel.com BUG=

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+158 lines, -16 lines)			Patch
M	base/prefs/json_pref_store.h	View	4 chunks	+7 lines, -0 lines	0 comments	Download
M	base/prefs/json_pref_store.cc	View	9 chunks	+24 lines, -8 lines	0 comments	Download
M	base/prefs/json_pref_store_unittest.cc	View	6 chunks	+127 lines, -8 lines	0 comments	Download

Total messages: 2 (0 generated)

Dan Beam

5 years, 7 months ago (2015-05-11 22:57:47 UTC) #2

eh, I'll just let raymes@ do it.  he's probably almost awake now.