Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: chromeos/network/shill_property_handler.cc

Issue 11361274: Add NetworkStateListDetailedView (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/shill_property_handler.cc
diff --git a/chromeos/network/shill_property_handler.cc b/chromeos/network/shill_property_handler.cc
index 9fecfd6d5a09f92e9304d7023b24deabc68889bb..676999d5f8db87166ede91328fa537067cb1ebf8 100644
--- a/chromeos/network/shill_property_handler.cc
+++ b/chromeos/network/shill_property_handler.cc
@@ -155,11 +155,10 @@ bool ShillPropertyHandler::ManagerPropertyChanged(const std::string& key,
bool notify_manager_changed = false;
if (key == flimflam::kServicesProperty) {
const base::ListValue* vlist = GetListValue(key, value);
- if (vlist)
- UpdateManagedList(ManagedState::MANAGED_TYPE_NETWORK, *vlist);
- } else if (key == flimflam::kServiceWatchListProperty) {
- const base::ListValue* vlist = GetListValue(key, value);
if (vlist) {
+ UpdateManagedList(ManagedState::MANAGED_TYPE_NETWORK, *vlist);
+ // TODO(stevenjb): Use kServiceWatchListProperty and request properties
+ // for new entries.
UpdateObservedNetworkServices(*vlist);
}
} else if (key == flimflam::kDevicesProperty) {
@@ -168,7 +167,7 @@ bool ShillPropertyHandler::ManagerPropertyChanged(const std::string& key,
UpdateManagedList(ManagedState::MANAGED_TYPE_DEVICE, *vlist);
} else if (key == flimflam::kAvailableTechnologiesProperty) {
const base::ListValue* vlist = GetListValue(key, value);
- if (vlist ) {
+ if (vlist) {
listener_->UpdateAvailableTechnologies(*vlist);
notify_manager_changed = true;
}

Powered by Google App Engine
This is Rietveld 408576698