Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 11361236: Merge 133569 - Web Inspector: JavaScript web workers debugging crashes (Closed)

Created:
8 years, 1 month ago by yurys
Modified:
8 years, 1 month ago
Reviewers:
yurys
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1312/
Visibility:
Public.

Description

Merge 133569 - Web Inspector: JavaScript web workers debugging crashes https://bugs.webkit.org/show_bug.cgi?id=101065 Reviewed by Alexander Pavlov. Source/WebCore: Clear m_pageInspector when page inspector instance is deleted. Disable worker inspection when front-end disconnects. Test: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html * inspector/InspectorWorkerAgent.cpp: (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::~WorkerFrontendChannel): notify WorkerMessagingProxy so that it can clear pointer to the channel. LayoutTests: Test that inspected page won't crash if inspected worker is terminated when it is paused on a breakpoint. * inspector-protocol/debugger-terminate-dedicated-worker-while-paused-expected.txt: Added. * inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html: Added. * platform/efl/TestExpectations: * platform/gtk/TestExpectations: * platform/mac/TestExpectations: * platform/qt/TestExpectations: * platform/win/TestExpectations: * platform/wincairo/TestExpectations: TBR=yurys@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134370

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
A + LayoutTests/inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector-protocol/debugger-terminate-dedicated-worker-while-paused-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/inspector/InspectorWorkerAgent.cpp View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
yurys
8 years, 1 month ago (2012-11-13 07:10:56 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698