Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1136123010: Another regression test for resolving references to "this" in strict mode. (Closed)

Created:
5 years, 7 months ago by Igor Sheludko
Modified:
5 years, 7 months ago
Reviewers:
wingo
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Another regression test for resolving references to "this" in strict mode. BUG=chromium:487105 LOG=N Committed: https://crrev.com/18b60594c40148f9daa67a168ce2dba17f4f16c3 Cr-Commit-Position: refs/heads/master@{#28480}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
A + test/mjsunit/regress/regress-crbug-487105.js View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Igor Sheludko
PTAL
5 years, 7 months ago (2015-05-19 09:56:51 UTC) #2
Igor Sheludko
This test still fails after https://codereview.chromium.org/1136883006
5 years, 7 months ago (2015-05-19 10:01:51 UTC) #4
wingo
On 2015/05/19 10:01:51, Igor Sheludko wrote: > This test still fails after https://codereview.chromium.org/1136883006 lgtm, thanks ...
5 years, 7 months ago (2015-05-19 11:12:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136123010/1
5 years, 7 months ago (2015-05-19 12:29:44 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 12:52:07 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 12:52:16 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/18b60594c40148f9daa67a168ce2dba17f4f16c3
Cr-Commit-Position: refs/heads/master@{#28480}

Powered by Google App Engine
This is Rietveld 408576698