Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 1136123004: events: keycodes: Add missing exports to keyboard_code_conversion_xkb.h (Closed)

Created:
5 years, 7 months ago by spang
Modified:
5 years, 7 months ago
Reviewers:
sadrul, Wez, kpschoedel
CC:
chromium-reviews, jdduke+watch_chromium.org, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

events: keycodes: Add missing exports to keyboard_code_conversion_xkb.h This fixes the component=shared_library build on Chrome OS. BUG=none TEST=cros chrome-sdk --board=link GYP_DEFINES="$GYP_DEFINES component=shared_library" gclient runhooks ninja -C out_link/Release chrome chrome_sandbox Committed: https://crrev.com/85ceb71724b3c44753546c5dae032faa7b3a3126 Cr-Commit-Position: refs/heads/master@{#329354}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M ui/events/keycodes/keyboard_code_conversion_xkb.h View 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
spang
5 years, 7 months ago (2015-05-11 20:25:15 UTC) #2
kpschoedel
lgtm
5 years, 7 months ago (2015-05-12 00:20:18 UTC) #3
Wez
lgtm
5 years, 7 months ago (2015-05-12 02:02:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136123004/1
5 years, 7 months ago (2015-05-12 04:18:37 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 04:59:56 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 05:01:03 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/85ceb71724b3c44753546c5dae032faa7b3a3126
Cr-Commit-Position: refs/heads/master@{#329354}

Powered by Google App Engine
This is Rietveld 408576698