Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Unified Diff: runtime/vm/flow_graph_compiler.cc

Issue 11361225: In optimized code use IC calls for instance calls that have no IC data instead of deoptimizing. The… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/code_generator.cc ('k') | runtime/vm/flow_graph_compiler_ia32.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler.cc
===================================================================
--- runtime/vm/flow_graph_compiler.cc (revision 14858)
+++ runtime/vm/flow_graph_compiler.cc (working copy)
@@ -145,6 +145,7 @@
block_info_(block_order_.length()),
deopt_infos_(),
is_optimizing_(is_optimizing),
+ may_reoptimize_(false),
bool_true_(Bool::ZoneHandle(Bool::True())),
bool_false_(Bool::ZoneHandle(Bool::False())),
double_class_(Class::ZoneHandle(
@@ -475,6 +476,39 @@
const Array& arguments_descriptor =
DartEntry::ArgumentsDescriptor(argument_count, argument_names);
uword label_address = 0;
+ if (is_optimizing() && (ic_data.NumberOfChecks() == 0)) {
+ if (ic_data.is_closure_call()) {
+ // This IC call may be closure call only.
+ label_address = StubCode::ClosureCallInlineCacheEntryPoint();
+ ExternalLabel target_label("InlineCache", label_address);
+ EmitInstanceCall(&target_label,
+ ICData::ZoneHandle(ic_data.AsUnaryClassChecks()),
+ arguments_descriptor, argument_count,
+ deopt_id, token_pos, locs);
+ return;
+ }
+ // Emit IC call that will count and thus may need reoptimization at
+ // return instruction.
+ may_reoptimize_ = true;
+ switch (ic_data.num_args_tested()) {
+ case 1:
+ label_address = StubCode::OneArgOptimizedCheckInlineCacheEntryPoint();
+ break;
+ case 2:
+ label_address = StubCode::TwoArgsOptimizedCheckInlineCacheEntryPoint();
+ break;
+ case 3:
+ label_address =
+ StubCode::ThreeArgsOptimizedCheckInlineCacheEntryPoint();
+ break;
+ default:
+ UNIMPLEMENTED();
+ }
+ ExternalLabel target_label("InlineCache", label_address);
+ EmitOptimizedInstanceCall(&target_label, ic_data, arguments_descriptor,
+ argument_count, deopt_id, token_pos, locs);
+ return;
+ }
if (is_optimizing()) {
// Megamorphic call requires one argument ICData.
ASSERT(ic_data.num_args_tested() == 1);
@@ -495,7 +529,6 @@
}
}
ExternalLabel target_label("InlineCache", label_address);
-
EmitInstanceCall(&target_label, ic_data, arguments_descriptor, argument_count,
deopt_id, token_pos, locs);
}
« no previous file with comments | « runtime/vm/code_generator.cc ('k') | runtime/vm/flow_graph_compiler_ia32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698