runtime/vm/intermediate_language.cc - Issue 11361225: In optimized code use IC calls for instance calls that have no IC data instead of deoptimizing. The…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language.cc

Issue 11361225: In optimized code use IC calls for instance calls that have no IC data instead of deoptimizing. The… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« runtime/vm/flow_graph_compiler_ia32.cc ('K') | « runtime/vm/flow_graph_compiler_x64.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | runtime/vm/intermediate_language_ia32.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/vm/intermediate_language.cc

===================================================================

--- runtime/vm/intermediate_language.cc (revision 14798)

+++ runtime/vm/intermediate_language.cc (working copy)

@@ -1871,7 +1871,8 @@

checked_argument_count());

}

if (compiler->is_optimizing()) {

- if (HasICData() && (ic_data()->NumberOfChecks() > 0)) {

+ ASSERT(HasICData());

+ if (ic_data()->NumberOfChecks() > 0) {

const ICData& unary_ic_data =

ICData::ZoneHandle(ic_data()->AsUnaryClassChecks());

compiler->GenerateInstanceCall(deopt_id(),

@@ -1881,11 +1882,16 @@

locs(),

unary_ic_data);

} else {

- Label* deopt =

- compiler->AddDeoptStub(deopt_id(), kDeoptInstanceCallNoICData);

- __ jmp(deopt);

+ // Call was not visited yet, use original ICData in order to populate it.

+ compiler->GenerateInstanceCall(deopt_id(),

+ token_pos(),

+ ArgumentCount(),

+ argument_names(),

+ locs(),

+ call_ic_data);

}

} else {

+ // Unoptimized code.

ASSERT(!HasICData());

compiler->AddCurrentDescriptor(PcDescriptors::kDeoptBefore,

deopt_id(),