Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: runtime/vm/flow_graph_compiler.cc

Issue 11361225: In optimized code use IC calls for instance calls that have no IC data instead of deoptimizing. The… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/code_generator.cc ('k') | runtime/vm/flow_graph_compiler_ia32.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_XXX. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_XXX.
6 6
7 #include "vm/flow_graph_compiler.h" 7 #include "vm/flow_graph_compiler.h"
8 8
9 #include "vm/dart_entry.h" 9 #include "vm/dart_entry.h"
10 #include "vm/debugger.h" 10 #include "vm/debugger.h"
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 parsed_function_(flow_graph.parsed_function()), 138 parsed_function_(flow_graph.parsed_function()),
139 block_order_(flow_graph.reverse_postorder()), 139 block_order_(flow_graph.reverse_postorder()),
140 current_block_(NULL), 140 current_block_(NULL),
141 exception_handlers_list_(NULL), 141 exception_handlers_list_(NULL),
142 pc_descriptors_list_(NULL), 142 pc_descriptors_list_(NULL),
143 stackmap_table_builder_( 143 stackmap_table_builder_(
144 is_optimizing ? new StackmapTableBuilder() : NULL), 144 is_optimizing ? new StackmapTableBuilder() : NULL),
145 block_info_(block_order_.length()), 145 block_info_(block_order_.length()),
146 deopt_infos_(), 146 deopt_infos_(),
147 is_optimizing_(is_optimizing), 147 is_optimizing_(is_optimizing),
148 may_reoptimize_(false),
148 bool_true_(Bool::ZoneHandle(Bool::True())), 149 bool_true_(Bool::ZoneHandle(Bool::True())),
149 bool_false_(Bool::ZoneHandle(Bool::False())), 150 bool_false_(Bool::ZoneHandle(Bool::False())),
150 double_class_(Class::ZoneHandle( 151 double_class_(Class::ZoneHandle(
151 Isolate::Current()->object_store()->double_class())), 152 Isolate::Current()->object_store()->double_class())),
152 parallel_move_resolver_(this) { 153 parallel_move_resolver_(this) {
153 ASSERT(assembler != NULL); 154 ASSERT(assembler != NULL);
154 } 155 }
155 156
156 157
157 FlowGraphCompiler::~FlowGraphCompiler() { 158 FlowGraphCompiler::~FlowGraphCompiler() {
(...skipping 310 matching lines...) Expand 10 before | Expand all | Expand 10 after
468 intptr_t token_pos, 469 intptr_t token_pos,
469 intptr_t argument_count, 470 intptr_t argument_count,
470 const Array& argument_names, 471 const Array& argument_names,
471 LocationSummary* locs, 472 LocationSummary* locs,
472 const ICData& ic_data) { 473 const ICData& ic_data) {
473 ASSERT(!ic_data.IsNull()); 474 ASSERT(!ic_data.IsNull());
474 ASSERT(FLAG_propagate_ic_data || (ic_data.NumberOfChecks() == 0)); 475 ASSERT(FLAG_propagate_ic_data || (ic_data.NumberOfChecks() == 0));
475 const Array& arguments_descriptor = 476 const Array& arguments_descriptor =
476 DartEntry::ArgumentsDescriptor(argument_count, argument_names); 477 DartEntry::ArgumentsDescriptor(argument_count, argument_names);
477 uword label_address = 0; 478 uword label_address = 0;
479 if (is_optimizing() && (ic_data.NumberOfChecks() == 0)) {
480 if (ic_data.is_closure_call()) {
481 // This IC call may be closure call only.
482 label_address = StubCode::ClosureCallInlineCacheEntryPoint();
483 ExternalLabel target_label("InlineCache", label_address);
484 EmitInstanceCall(&target_label,
485 ICData::ZoneHandle(ic_data.AsUnaryClassChecks()),
486 arguments_descriptor, argument_count,
487 deopt_id, token_pos, locs);
488 return;
489 }
490 // Emit IC call that will count and thus may need reoptimization at
491 // return instruction.
492 may_reoptimize_ = true;
493 switch (ic_data.num_args_tested()) {
494 case 1:
495 label_address = StubCode::OneArgOptimizedCheckInlineCacheEntryPoint();
496 break;
497 case 2:
498 label_address = StubCode::TwoArgsOptimizedCheckInlineCacheEntryPoint();
499 break;
500 case 3:
501 label_address =
502 StubCode::ThreeArgsOptimizedCheckInlineCacheEntryPoint();
503 break;
504 default:
505 UNIMPLEMENTED();
506 }
507 ExternalLabel target_label("InlineCache", label_address);
508 EmitOptimizedInstanceCall(&target_label, ic_data, arguments_descriptor,
509 argument_count, deopt_id, token_pos, locs);
510 return;
511 }
478 if (is_optimizing()) { 512 if (is_optimizing()) {
479 // Megamorphic call requires one argument ICData. 513 // Megamorphic call requires one argument ICData.
480 ASSERT(ic_data.num_args_tested() == 1); 514 ASSERT(ic_data.num_args_tested() == 1);
481 label_address = StubCode::MegamorphicCallEntryPoint(); 515 label_address = StubCode::MegamorphicCallEntryPoint();
482 } else { 516 } else {
483 switch (ic_data.num_args_tested()) { 517 switch (ic_data.num_args_tested()) {
484 case 1: 518 case 1:
485 label_address = StubCode::OneArgCheckInlineCacheEntryPoint(); 519 label_address = StubCode::OneArgCheckInlineCacheEntryPoint();
486 break; 520 break;
487 case 2: 521 case 2:
488 label_address = StubCode::TwoArgsCheckInlineCacheEntryPoint(); 522 label_address = StubCode::TwoArgsCheckInlineCacheEntryPoint();
489 break; 523 break;
490 case 3: 524 case 3:
491 label_address = StubCode::ThreeArgsCheckInlineCacheEntryPoint(); 525 label_address = StubCode::ThreeArgsCheckInlineCacheEntryPoint();
492 break; 526 break;
493 default: 527 default:
494 UNIMPLEMENTED(); 528 UNIMPLEMENTED();
495 } 529 }
496 } 530 }
497 ExternalLabel target_label("InlineCache", label_address); 531 ExternalLabel target_label("InlineCache", label_address);
498
499 EmitInstanceCall(&target_label, ic_data, arguments_descriptor, argument_count, 532 EmitInstanceCall(&target_label, ic_data, arguments_descriptor, argument_count,
500 deopt_id, token_pos, locs); 533 deopt_id, token_pos, locs);
501 } 534 }
502 535
503 536
504 void FlowGraphCompiler::GenerateStaticCall(intptr_t deopt_id, 537 void FlowGraphCompiler::GenerateStaticCall(intptr_t deopt_id,
505 intptr_t token_pos, 538 intptr_t token_pos,
506 const Function& function, 539 const Function& function,
507 intptr_t argument_count, 540 intptr_t argument_count,
508 const Array& argument_names, 541 const Array& argument_names,
(...skipping 408 matching lines...) Expand 10 before | Expand all | Expand 10 after
917 ASSERT(Utils::IsInt(31, disp)); 950 ASSERT(Utils::IsInt(31, disp));
918 return FieldAddress(array, disp); 951 return FieldAddress(array, disp);
919 } 952 }
920 default: 953 default:
921 UNIMPLEMENTED(); 954 UNIMPLEMENTED();
922 return FieldAddress(SPREG, 0); 955 return FieldAddress(SPREG, 0);
923 } 956 }
924 } 957 }
925 958
926 } // namespace dart 959 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/code_generator.cc ('k') | runtime/vm/flow_graph_compiler_ia32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698