src/trusted/validator_arm/model.h - Issue 11361222: ARM validator: fix sandbox escape with SP update at the end of the last bundle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/validator_arm/model.h

Issue 11361222: ARM validator: fix sandbox escape with SP update at the end of the last bundle (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: Fix comments from mseaborn. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/trusted/validator_arm/model.h

diff --git a/src/trusted/validator_arm/model.h b/src/trusted/validator_arm/model.h

index 9d704c937a2fadfb6e9372692a6000e065d3d135..55c2f272e42011f90e934a240ce5a0f56b70c1de 100644

--- a/src/trusted/validator_arm/model.h

+++ b/src/trusted/validator_arm/model.h

@@ -286,6 +286,9 @@ static const uint32_t kHaltFill = NACL_INSTR_ARM_HALT_FILL;

static const uint32_t kAbortNow = NACL_INSTR_ARM_ABORT_NOW;

static const uint32_t kFailValidation = NACL_INSTR_ARM_FAIL_VALIDATION;

+// Not-so-special instructions.

+static const uint32_t kNop = NACL_INSTR_ARM_NOP;

// Models an instruction, either a 32-bit ARM instruction of unspecified type,

// or one word (16-bit) and two word (32-bit) THUMB instructions.

« no previous file with comments | « src/include/arm_sandbox.h ('k') | src/trusted/validator_arm/validator.cc » ('j') | no next file with comments »