src/include/arm_sandbox.h - Issue 11361222: ARM validator: fix sandbox escape with SP update at the end of the last bundle

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/include/arm_sandbox.h

Issue 11361222: ARM validator: fix sandbox escape with SP update at the end of the last bundle (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 /*	1 /*

2 * Copyright (c) 2012 The Native Client Authors. All rights reserved.	2 * Copyright (c) 2012 The Native Client Authors. All rights reserved.

3 * Use of this source code is governed by a BSD-style license that can be	3 * Use of this source code is governed by a BSD-style license that can be

4 * found in the LICENSE file.	4 * found in the LICENSE file.

5 */	5 */

6	6

7 /*	7 /*

8 * Minimal ARM sandbox constants.	8 * Minimal ARM sandbox constants.

9 *	9 *

10 * These constants are used in C code as well as assembly, hence the use of	10 * These constants are used in C code as well as assembly, hence the use of

(...skipping 49 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
60 #define NACL_INSTR_ARM_ABORT_NOW 0xE7FEDEF0	60 #define NACL_INSTR_ARM_ABORT_NOW 0xE7FEDEF0

61	61

62 /*	62 /*

63 * UDF #0xEDE1: always fail validation.	63 * UDF #0xEDE1: always fail validation.

64 *	64 *

65 * It's guaranteed to always fail, and can be used to initialize buffers	65 * It's guaranteed to always fail, and can be used to initialize buffers

66 * that are expected to be filled later.	66 * that are expected to be filled later.

67 */	67 */

68 #define NACL_INSTR_ARM_FAIL_VALIDATION 0xE7FEDEF1	68 #define NACL_INSTR_ARM_FAIL_VALIDATION 0xE7FEDEF1

69	69

	70 /*

	71 * NOP.
	Mark Seaborn 2012/11/13 00:30:18 The comment doesn't add any information. Maybe "N The comment doesn't add any information. Maybe "No-op: mov r0, r0" (assuming it's a mov like that?). JF 2012/11/13 00:49:42 Comment added. Comment added.
	72 */

	73 #define NACL_INSTR_ARM_NOP 0xE320F000

	74

70 #endif /* NATIVE_CLIENT_SRC_INCLUDE_ARM_SANDBOX_H_ */	75 #endif /* NATIVE_CLIENT_SRC_INCLUDE_ARM_SANDBOX_H_ */

OLD	NEW

« no previous file with comments | « no previous file | src/trusted/validator_arm/model.h » ('j') | src/trusted/validator_arm/model.h » ('J')