Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5878)

Unified Diff: chrome/test/perf/page_cycler_test.cc

Issue 11361218: Revert 165685 - Revert 163638 - Adds units for all Chromium perf tests. These units are recorded in… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.croc ('k') | chrome/test/perf/perf_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/perf/page_cycler_test.cc
===================================================================
--- chrome/test/perf/page_cycler_test.cc (revision 167179)
+++ chrome/test/perf/page_cycler_test.cc (working copy)
@@ -269,7 +269,8 @@
}
private:
- void PrintMemoryHistogram(const std::string& name) {
+ void PrintMemoryHistogram(const std::string& name,
+ const std::string& units) {
scoped_refptr<TabProxy> tab(GetActiveTab());
ASSERT_TRUE(tab.get());
std::wstring whistogram;
@@ -281,17 +282,17 @@
base::SysUTF8ToWide(name) + L"\") : '')",
&whistogram));
std::string histogram = base::SysWideToNativeMB(whistogram);
- printf("HISTOGRAM %s: %s = %s\n",
- name.c_str(), name.c_str(), histogram.c_str());
+ printf("HISTOGRAM %s: %s = %s %s\n",
+ name.c_str(), name.c_str(), histogram.c_str(), units.c_str());
}
void PrintMemoryHistograms() {
ASSERT_NO_FATAL_FAILURE(PrintMemoryHistogram(
- "V8.MemoryExternalFragmentationTotal"));
+ "V8.MemoryExternalFragmentationTotal", "percent"));
ASSERT_NO_FATAL_FAILURE(PrintMemoryHistogram(
- "V8.MemoryHeapSampleTotalCommitted"));
+ "V8.MemoryHeapSampleTotalCommitted", "kb"));
ASSERT_NO_FATAL_FAILURE(PrintMemoryHistogram(
- "V8.MemoryHeapSampleTotalUsed"));
+ "V8.MemoryHeapSampleTotalUsed", "kb"));
}
protected:
« no previous file with comments | « build/common.croc ('k') | chrome/test/perf/perf_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698