Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Issue 11361204: Added helper for upload/download of canned nexes. (Closed)

Created:
8 years, 1 month ago by Robert Muth (chromium)
Modified:
8 years, 1 month ago
Reviewers:
bradnelson, bradn
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Added helper for upload/download of canned nexes. Cleaned up the rest of script to reduce code duplication. BUG= Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=10263

Patch Set 1 #

Patch Set 2 : p #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -40 lines) Patch
M buildbot/file_up_down_load.sh View 1 2 3 4 10 chunks +89 lines, -40 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Robert Muth (chromium)
PTAL
8 years, 1 month ago (2012-11-10 22:33:02 UTC) #1
Robert Muth (chromium)
ping
8 years, 1 month ago (2012-11-13 18:50:06 UTC) #2
bradn
lgtm
8 years, 1 month ago (2012-11-13 22:26:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/robertm@chromium.org/11361204/3
8 years, 1 month ago (2012-11-14 00:07:31 UTC) #4
commit-bot: I haz the power
8 years, 1 month ago (2012-11-14 00:07:35 UTC) #5
Presubmit check for 11361204-3 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  buildbot/file_up_down_load.sh, line 169, 82 chars

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

Powered by Google App Engine
This is Rietveld 408576698