Chromium Code Reviews| Index: tests/language/bool_test.dart |
| diff --git a/tests/language/bool_test.dart b/tests/language/bool_test.dart |
| index 8263d0abdc8ff515e5e25bdd1284b2b61c2c5094..8f0c9805ca3218d6b2aab2ef4d241d0955150a44 100644 |
| --- a/tests/language/bool_test.dart |
| +++ b/tests/language/bool_test.dart |
| @@ -9,14 +9,14 @@ class BoolTest { |
| static void testEquality() { |
| Expect.equals(true, true); |
| Expect.equals(false, false); |
| - Expect.equals(true, true === true); |
| - Expect.equals(false, true === false); |
| - Expect.equals(true, false === false); |
| - Expect.equals(false, false === true); |
| - Expect.equals(false, true !== true); |
| - Expect.equals(true, true !== false); |
| - Expect.equals(false, false !== false); |
| - Expect.equals(true, false !== true); |
| + Expect.equals(true, identical(true, true)); |
|
Lasse Reichstein Nielsen
2012/11/12 13:10:41
Expect.identical(true, true)
and
Expect.isFalse(
floitsch
2012/11/12 22:18:43
Changed to .isTrue / .isFalse.
Kept the identicals
|
| + Expect.equals(false, identical(true, false)); |
| + Expect.equals(true, identical(false, false)); |
| + Expect.equals(false, identical(false, true)); |
| + Expect.equals(false, !identical(true, true)); |
| + Expect.equals(true, !identical(true, false)); |
| + Expect.equals(false, !identical(false, false)); |
| + Expect.equals(true, !identical(false, true)); |
| Expect.equals(true, true == true); |
| Expect.equals(false, true == false); |
| Expect.equals(true, false == false); |
| @@ -25,22 +25,22 @@ class BoolTest { |
| Expect.equals(true, true != false); |
| Expect.equals(false, false != false); |
| Expect.equals(true, false != true); |
| - Expect.equals(true, true === (true == true)); |
| - Expect.equals(true, false === (true == false)); |
| - Expect.equals(true, true === (false == false)); |
| - Expect.equals(true, false === (false == true)); |
| - Expect.equals(false, true !== (true == true)); |
| - Expect.equals(false, false !== (true == false)); |
| - Expect.equals(false, true !== (false == false)); |
| - Expect.equals(false, false !== (false == true)); |
| - Expect.equals(false, false === (true == true)); |
| - Expect.equals(false, true === (true == false)); |
| - Expect.equals(false, false === (false == false)); |
| - Expect.equals(false, true === (false == true)); |
| - Expect.equals(true, false !== (true == true)); |
| - Expect.equals(true, true !== (true == false)); |
| - Expect.equals(true, false !== (false == false)); |
| - Expect.equals(true, true !== (false == true)); |
| + Expect.equals(true, identical(true, (true == true))); |
| + Expect.equals(true, identical(false, (true == false))); |
| + Expect.equals(true, identical(true, (false == false))); |
| + Expect.equals(true, identical(false, (false == true))); |
| + Expect.equals(false, !identical(true, (true == true))); |
| + Expect.equals(false, !identical(false, (true == false))); |
| + Expect.equals(false, !identical(true, (false == false))); |
| + Expect.equals(false, !identical(false, (false == true))); |
| + Expect.equals(false, identical(false, (true == true))); |
| + Expect.equals(false, identical(true, (true == false))); |
| + Expect.equals(false, identical(false, (false == false))); |
| + Expect.equals(false, identical(true, (false == true))); |
| + Expect.equals(true, !identical(false, (true == true))); |
| + Expect.equals(true, !identical(true, (true == false))); |
| + Expect.equals(true, !identical(false, (false == false))); |
| + Expect.equals(true, !identical(true, (false == true))); |
| // Expect.equals could rely on a broken boolean equality. |
| if (true == false) { |
| throw "Expect.equals broken"; |
| @@ -48,10 +48,10 @@ class BoolTest { |
| if (false == true) { |
| throw "Expect.equals broken"; |
| } |
| - if (true === false) { |
| + if (identical(true, false)) { |
| throw "Expect.equals broken"; |
| } |
| - if (false === true) { |
| + if (identical(false, true)) { |
| throw "Expect.equals broken"; |
| } |
| if (true == true) { |
| @@ -62,11 +62,11 @@ class BoolTest { |
| } else { |
| throw "Expect.equals broken"; |
| } |
| - if (true === true) { |
| + if (identical(true, true)) { |
| } else { |
| throw "Expect.equals broken"; |
| } |
| - if (false === false) { |
| + if (identical(false, false)) { |
| } else { |
| throw "Expect.equals broken"; |
| } |
| @@ -78,11 +78,11 @@ class BoolTest { |
| } else { |
| throw "Expect.equals broken"; |
| } |
| - if (true !== false) { |
| + if (!identical(true, false)) { |
| } else { |
| throw "Expect.equals broken"; |
| } |
| - if (false !== true) { |
| + if (!identical(false, true)) { |
| } else { |
| throw "Expect.equals broken"; |
| } |
| @@ -92,10 +92,10 @@ class BoolTest { |
| if (false != false) { |
| throw "Expect.equals broken"; |
| } |
| - if (true !== true) { |
| + if (!identical(true, true)) { |
| throw "Expect.equals broken"; |
| } |
| - if (false !== false) { |
| + if (!identical(false, false)) { |
| throw "Expect.equals broken"; |
| } |
| } |