tests/compiler/dart2js/type_equals_test.dart - Issue 11361190: a === b -> identical(a, b)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/compiler/dart2js/type_equals_test.dart

Issue 11361190: a === b -> identical(a, b) (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: 80chars. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/compiler/dart2js/type_equals_test.dart

diff --git a/tests/compiler/dart2js/type_equals_test.dart b/tests/compiler/dart2js/type_equals_test.dart

index 72eef67c1b2a886c17e8c34b50056c8664878946..09303ece33fea3a6edb0da10d27b855b81c2525d 100644

--- a/tests/compiler/dart2js/type_equals_test.dart

+++ b/tests/compiler/dart2js/type_equals_test.dart

@@ -18,8 +18,8 @@ bool test(compiler, String name1, String name2, {bool expect}) {

var element2 = clazz.buildScope().lookup(buildSourceString(name2));

Expect.isNotNull(element1);

Expect.isNotNull(element2);

- Expect.isTrue(element1.kind === ElementKind.FUNCTION);

- Expect.isTrue(element2.kind === ElementKind.FUNCTION);

+ Expect.isTrue(identical(element1.kind, ElementKind.FUNCTION));

+ Expect.isTrue(identical(element2.kind, ElementKind.FUNCTION));

Lasse Reichstein Nielsen 2012/11/12 13:10:41 Again, consider using ==.

floitsch 2012/11/12 22:18:43 Done.

FunctionSignature signature1 = element1.computeSignature(compiler);

FunctionSignature signature2 = element2.computeSignature(compiler);