Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: tests/compiler/dart2js/metadata_test.dart

Issue 11361190: a === b -> identical(a, b) (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: 80chars. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/compiler/dart2js/metadata_test.dart
diff --git a/tests/compiler/dart2js/metadata_test.dart b/tests/compiler/dart2js/metadata_test.dart
index df35845a0e3098ff23fdeb10c8ab0166d6bc30dd..978a3d2adc92b231084ef9ae200bb82f2d9f4ff0 100644
--- a/tests/compiler/dart2js/metadata_test.dart
+++ b/tests/compiler/dart2js/metadata_test.dart
@@ -44,7 +44,7 @@ void checkAnnotation(String name, String declaration,
MetadataAnnotation annotation2 = element.metadata.tail.head;
annotation1.ensureResolved(compiler);
annotation2.ensureResolved(compiler);
- Expect.isTrue(annotation1 !== annotation2, 'expected unique instances');
+ Expect.isTrue(!identical(annotation1, annotation2), 'expected unique instances');
Lasse Reichstein Nielsen 2012/11/12 13:10:41 isFalse and remove the '!'. And long line.
floitsch 2012/11/12 22:18:43 Done.
Expect.notEquals(annotation1, annotation2, 'expected unequal instances');
Constant value1 = annotation1.value;
Constant value2 = annotation2.value;
@@ -97,7 +97,7 @@ void checkAnnotation(String name, String declaration,
MetadataAnnotation annotation2 = element.metadata.tail.head;
annotation1.ensureResolved(compiler);
annotation2.ensureResolved(compiler);
- Expect.isTrue(annotation1 !== annotation2, 'expected unique instances');
+ Expect.isTrue(!identical(annotation1, annotation2), 'expected unique instances');
Lasse Reichstein Nielsen 2012/11/12 13:10:41 Ditto.
floitsch 2012/11/12 22:18:43 Done.
Expect.notEquals(annotation1, annotation2, 'expected unequal instances');
Constant value1 = annotation1.value;
Constant value2 = annotation2.value;

Powered by Google App Engine
This is Rietveld 408576698