sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart - Issue 11361190: a === b -> identical(a, b)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart

Issue 11361190: a === b -> identical(a, b) (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: 80chars. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« samples/third_party/dromaeo/Suites.dart ('K') | « sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart ('k') | sdk/lib/_internal/compiler/implementation/lib/interceptors.dart » ('j') | sdk/lib/_internal/compiler/implementation/ssa/builder.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart b/sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart

index 7b92fcd3607e3f016f67936970dbe20fc6401ec6..7f6148394ca5609830898e80d7f6171693fc8822 100644

--- a/sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart

@@ -105,7 +105,7 @@ function(cls, desc) {

}

var hasOwnProperty = Object.prototype.hasOwnProperty;

for (var method in desc) {

- if (method !== '') {

+ if (method != '') {

Lasse Reichstein Nielsen 2012/11/12 13:10:41 .isEmpty.

floitsch 2012/11/12 22:18:43 Actually inside a string (thus JavaScript code). R

if (hasOwnProperty.call(desc, method)) {

$dynamicName(method)[cls] = desc[method];

}