samples/third_party/dromaeo/Suites.dart - Issue 11361190: a === b -> identical(a, b)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: samples/third_party/dromaeo/Suites.dart

Issue 11361190: a === b -> identical(a, b) (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: 80chars. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: samples/third_party/dromaeo/Suites.dart

diff --git a/samples/third_party/dromaeo/Suites.dart b/samples/third_party/dromaeo/Suites.dart

index 8af8ea1f4ec4d970ff8a9fc1d183ed1378655f31..fb764948fd6419d628012e35b37a3b1a5a055c70 100644

--- a/samples/third_party/dromaeo/Suites.dart

+++ b/samples/third_party/dromaeo/Suites.dart

@@ -92,7 +92,7 @@ class Suites {

static var _SUITE_DESCRIPTIONS;

static List<SuiteDescription> get SUITE_DESCRIPTIONS {

- if (null !== _SUITE_DESCRIPTIONS) {

+ if (null != _SUITE_DESCRIPTIONS) {

Lasse Reichstein Nielsen 2012/11/12 13:10:41 Swap operands, this is unreadable.

floitsch 2012/11/12 22:18:43 Done.

return _SUITE_DESCRIPTIONS;

}

_SUITE_DESCRIPTIONS = <SuiteDescription>[];

@@ -113,7 +113,7 @@ class Suites {

combined.add(lib);

lib = ':$lib';

}

- final name = null === variant

+ final name = null == variant

Lasse Reichstein Nielsen 2012/11/12 13:10:41 ditto here. And parenthesize the comparison.

floitsch 2012/11/12 22:18:43 Done.

? suite.name

: '${suite.name} ($platform$lib)';

_SUITE_DESCRIPTIONS.add(new SuiteDescription(