samples/swarm/BiIterator.dart - Issue 11361190: a === b -> identical(a, b)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: samples/swarm/BiIterator.dart

Issue 11361190: a === b -> identical(a, b) (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: 80chars. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: samples/swarm/BiIterator.dart

diff --git a/samples/swarm/BiIterator.dart b/samples/swarm/BiIterator.dart

index 58779be7be5c8a3b4d18de95624153d964d16b1a..a6a97cd318937a6395c4f8092f14195a2fc6426b 100644

--- a/samples/swarm/BiIterator.dart

+++ b/samples/swarm/BiIterator.dart

@@ -58,7 +58,7 @@ class BiIterator<E> {

void jumpToValue(E val) {

for (int i = 0; i < list.length; i++) {

- if (list[i] === val) {

+ if (identical(list[i], val)) {

Lasse Reichstein Nielsen 2012/11/12 13:10:41 Arguably this should never have been === to begin

floitsch 2012/11/12 22:18:43 Maybe, but I don't know if they depend on it. Keep

currentIndex.value = i;

break;

}