chrome/common/extensions/extension.h - Issue 11361189: Initial skeleton for System Indicator API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension.h

Issue 11361189: Initial skeleton for System Indicator API (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Rebase; Make system_indicator manifest entry grant systemIndicator permission. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/extension.h

diff --git a/chrome/common/extensions/extension.h b/chrome/common/extensions/extension.h

index 8efd7cf9f3911a8b3854ab057d2776682ad2ec10..6bc9153747139fdeaf7943a528a09a828aaf5188 100644

--- a/chrome/common/extensions/extension.h

+++ b/chrome/common/extensions/extension.h

@@ -910,7 +910,7 @@ class Extension : public base::RefCountedThreadSafe<Extension> {

const base::DictionaryValue& handler_info,

string16* error);

bool LoadFileHandlers(string16* error);

- bool LoadExtensionFeatures(const APIPermissionSet& api_permissions,

+ bool LoadExtensionFeatures(APIPermissionSet& api_permissions,

not at google - send to devlin 2012/11/20 23:58:08 Non const pointers bad. If this isn't const anymor

dewittj 2012/11/21 22:09:41 I've been revealed as a C++ n00b. Fixed.

string16* error);

bool LoadDevToolsPage(string16* error);

bool LoadInputComponents(const APIPermissionSet& api_permissions,

@@ -919,6 +919,7 @@ class Extension : public base::RefCountedThreadSafe<Extension> {

bool LoadPageAction(string16* error);

bool LoadBrowserAction(string16* error);

bool LoadScriptBadge(string16* error);

+ bool LoadSystemIndicator(APIPermissionSet& api_permissions, string16* error);

bool LoadFileBrowserHandlers(string16* error);

// Helper method to load a FileBrowserHandlerList from the manifest.

FileBrowserHandlerList* LoadFileBrowserHandlersHelper(