Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4223)

Unified Diff: chrome/renderer/resources/extensions/system_indicator_custom_bindings.js

Issue 11361189: Initial skeleton for System Indicator API (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Add manifest parsing and integrate with extension action api handlers. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/system_indicator_custom_bindings.js
diff --git a/chrome/renderer/resources/extensions/browser_action_custom_bindings.js b/chrome/renderer/resources/extensions/system_indicator_custom_bindings.js
similarity index 82%
copy from chrome/renderer/resources/extensions/browser_action_custom_bindings.js
copy to chrome/renderer/resources/extensions/system_indicator_custom_bindings.js
index 9d1d92eb35fc1d13d739ef48368e6509f38493c4..e354f12bd132123685e5b060516fad8d9e4b7814 100644
--- a/chrome/renderer/resources/extensions/browser_action_custom_bindings.js
+++ b/chrome/renderer/resources/extensions/system_indicator_custom_bindings.js
@@ -7,11 +7,12 @@
var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();
var setIcon = require('setIcon').setIcon;
-chromeHidden.registerCustomHook('browserAction', function(bindingsAPI) {
+chromeHidden.registerCustomHook('systemIndicator', function(bindingsAPI) {
not at google - send to devlin 2012/11/21 23:39:23 if you're up for a little bit of cleanup along the
not at google - send to devlin 2012/11/21 23:43:36 A good time for this might be in your follow-up.
dewittj 2012/11/26 18:32:58 OK.
var apiFunctions = bindingsAPI.apiFunctions;
apiFunctions.setHandleRequest('setIcon', function(details, callback) {
setIcon(details, callback, this.name, this.definition.parameters,
- 'browser action');
+ 'system indicator');
});
});
+

Powered by Google App Engine
This is Rietveld 408576698