Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Side by Side Diff: chrome/browser/extensions/api/system_indicator/system_indicator_api.cc

Issue 11361189: Initial skeleton for System Indicator API (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Add menu handling stubs, address formatting issues Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/extensions/api/system_indicator/system_indicator_api.h"
6
7 #include "chrome/browser/extensions/extension_system.h"
8 #include "chrome/common/extensions/api/experimental_system_indicator.h"
9
10 namespace extensions {
11
12 SystemIndicatorSetIconURLFunction::SystemIndicatorSetIconURLFunction() {}
13
14 bool SystemIndicatorSetIconURLFunction::RunImpl() {
15 scoped_ptr<api::experimental_system_indicator::SetIconURL::Params> params(
16 api::experimental_system_indicator::SetIconURL::Params::Create(*args_));
17 EXTENSION_FUNCTION_VALIDATE(params.get());
18
19 return true;
20 }
21
22 SystemIndicatorSetIconDataFunction::SystemIndicatorSetIconDataFunction() {}
23
24 bool SystemIndicatorSetIconDataFunction::RunImpl() {
25 scoped_ptr<api::experimental_system_indicator::SetIconData::Params> params(
26 api::experimental_system_indicator::SetIconData::Params::Create(*args_));
27 /* Validation is tricky since instanceOf can't be used for ImageData */
jianli 2012/11/14 19:27:41 nit: We usually start the comment with "//".
dewittj 2012/11/16 00:56:28 Removed comment since I found a way to get params
28 return true;
29 }
30
31 SystemIndicatorSetMenuFunction::SystemIndicatorSetMenuFunction() {}
32
33 bool SystemIndicatorSetMenuFunction::RunImpl() {
34 scoped_ptr<api::experimental_system_indicator::SetMenu::Params> params(
35 api::experimental_system_indicator::SetMenu::Params::Create(*args_));
36 EXTENSION_FUNCTION_VALIDATE(params.get());
37 return true;
38 }
39
40
not at google - send to devlin 2012/11/14 19:53:20 nit: remove blank line
dewittj 2012/11/16 00:56:28 Done
41 SystemIndicatorShowFunction::SystemIndicatorShowFunction() {}
42
43 bool SystemIndicatorShowFunction::RunImpl() {
44 return true;
45 }
46
47 SystemIndicatorHideFunction::SystemIndicatorHideFunction() {}
48
49 bool SystemIndicatorHideFunction::RunImpl() {
50 return true;
51 }
52
53 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698