Initial skeleton for System Indicator API

chrome/common/extensions/extension.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/extension.h"
 
 #include <ostream>
 
 #include "base/base64.h"
 #include "base/basictypes.h"
@@ skipping 2168 matching lines @@
       if (!LoadFileHandler(*iter, *handler, error))
         return false;
     } else {
       *error = ASCIIToUTF16(errors::kInvalidFileHandlers);
       return false;
     }
   }
   return true;
 }
 
-bool Extension::LoadExtensionFeatures(const APIPermissionSet& api_permissions,
+bool Extension::LoadExtensionFeatures(APIPermissionSet& api_permissions,
                                       string16* error) {
   if (manifest_->HasKey(keys::kConvertedFromUserScript))
     manifest_->GetBoolean(keys::kConvertedFromUserScript,
                           &converted_from_user_script_);
 
   if (!LoadDevToolsPage(error) ||
       !LoadInputComponents(api_permissions, error) ||
       !LoadContentScripts(error) ||
       !LoadPageAction(error) ||
       !LoadBrowserAction(error) ||
+      !LoadSystemIndicator(api_permissions, error) ||
       !LoadScriptBadge(error) ||
       !LoadFileBrowserHandlers(error) ||
       !LoadChromeURLOverrides(error) ||
       !LoadOmnibox(error) ||
       !LoadTextToSpeechVoices(error) ||
       !LoadIncognitoMode(error) ||
       !LoadFileHandlers(error) ||
       !LoadContentSecurityPolicy(error))
     return false;
 
@@ skipping 226 matching lines @@
     return false;
   }
 
   browser_action_info_ = LoadExtensionActionInfoHelper(
       browser_action_value, Extension::ActionInfo::TYPE_BROWSER, error);
   if (!browser_action_info_.get())
     return false;  // Failed to parse browser action definition.
   return true;
 }
 
+bool Extension::LoadSystemIndicator(APIPermissionSet& api_permissions,
+                                    string16* error) {
+  if (!manifest_->HasKey(keys::kSystemIndicator)) {
+    return true;
+  }
+
+  DictionaryValue* system_indicator_value = NULL;
+  if (!manifest_->GetDictionary(keys::kSystemIndicator,
+                                &system_indicator_value)) {
+    *error = ASCIIToUTF16(errors::kInvalidSystemIndicator);
+    return false;
+  }
+
+  // Because the manifest was successfully parsed, auto-grant the permission.
+  api_permissions.insert(APIPermission::kSystemIndicator);

[not at google - send to devlin, 2012/11/20 23:58:08]

I like this idea. We should make it happen for all extension actions (except for
script badges - they should always get the permission - but that's another
story).

Note that we were going to build this into the Features system but that didn't
quite happen.

[dewittj, 2012/11/21 22:09:41]

Will add to the rest of the _actions in a separate CL.  What is the state of
Features, is it still being developed?

[not at google - send to devlin, 2012/11/21 23:39:23]

Ok.

The status of the Feature system is partially in this change:
https://codereview.chromium.org/10025007/ but mostly in Aaron's brain.

+
+  // TODO(dewittj) Parse browser action section.
+  return true;

[not at google - send to devlin, 2012/11/20 23:58:08]

Why not just implement it now?

[dewittj, 2012/11/21 22:09:41]

I still have doubts about what the final format will look like, since
system_indicator will need to support more resolutions than just 19x19@1x and
19x19@2x.  But for now, I have just reused the manifest parser from the other
extension_actions and will update once I get a strategy together for that.

[not at google - send to devlin, 2012/11/21 23:39:23]

Yep sounds good, but I hope that any improvements you need to make here would
(may need to) also apply to the other types of extension actions.

+}
+
 bool Extension::LoadScriptBadge(string16* error) {
   if (manifest_->HasKey(keys::kScriptBadge)) {
     if (!FeatureSwitch::script_badges()->IsEnabled()) {
       // So as to not confuse developers if they specify a script badge section
       // in the manifest, show a warning if the script badge declaration isn't
       // going to have any effect.
       install_warnings_.push_back(
           InstallWarning(InstallWarning::FORMAT_TEXT,
                          errors::kScriptBadgeRequiresFlag));
     }
@@ skipping 1639 matching lines @@
 
 UpdatedExtensionPermissionsInfo::UpdatedExtensionPermissionsInfo(
     const Extension* extension,
     const PermissionSet* permissions,
     Reason reason)
     : reason(reason),
       extension(extension),
       permissions(permissions) {}
 
 }   // namespace extensions