Initial skeleton for System Indicator API

chrome/browser/extensions/api/system_indicator/system_indicator_api.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_EXTENSIONS_API_SYSTEM_INDICATOR_SYSTEM_INDICATOR_API_H_
+#define CHROME_BROWSER_EXTENSIONS_API_SYSTEM_INDICATOR_SYSTEM_INDICATOR_API_H_
+
+#include "chrome/browser/extensions/extension_function.h"
+
+namespace extensions {
+

[not at google - send to devlin, 2012/11/16 17:42:04]

It seems to me that the eventual implementation for this feature will be to add
an ExtensionAction for the system indicator and hang it off Extension (in the
way that browser/page actions and script badges do).

Which means that we can get most of the implementation for free by making these
functions point to their ExtensionAction equivalents (ditto), just being
selective about what functions we expose to it (ditto).

Advantages to using ExtensionAction: consistency, icon handling for free, simple
implementation, you can add better tests for it now, and probably more.

I am not sure how nicely this will play into using IDL for this feature. It
might be tricky. But JSON isn't that bad (and it will be even better once
crbug.com/141318 is fixed but I guess that's moot).

[dewittj, 2012/11/16 19:13:57]

In fact I have already written part of a solution in which this API is just
another extensionaction.  There are some mismatches (ubiquitous tab_ids for
example) but overall it's a pretty good fit.

Do you mind if I go forward with IDL until I hit an insurmountable barrier?

[not at google - send to devlin, 2012/11/16 19:21:09]

Yes the tab ID stuff is a bit problematic, particularly since it doesn't make
sense for apps, but I think it will shake out ok if you just leave it out of the
schema.
Sounds fine.

+class SystemIndicatorSetIconFunction : public SyncExtensionFunction {
+ public:
+  SystemIndicatorSetIconFunction();
+  DECLARE_EXTENSION_FUNCTION_NAME("systemIndicator.setIcon")
+
+ protected:
+  virtual ~SystemIndicatorSetIconFunction() {}
+
+  virtual bool RunImpl() OVERRIDE;
+};
+
+class SystemIndicatorEnableFunction : public SyncExtensionFunction {
+ public:
+  SystemIndicatorEnableFunction();
+  DECLARE_EXTENSION_FUNCTION_NAME("systemIndicator.enable")
+
+ protected:
+  virtual ~SystemIndicatorEnableFunction() {}
+
+  virtual bool RunImpl() OVERRIDE;
+};
+
+class SystemIndicatorDisableFunction : public SyncExtensionFunction {
+ public:
+  SystemIndicatorDisableFunction();
+  DECLARE_EXTENSION_FUNCTION_NAME("systemIndicator.disable");
+
+ protected:
+  virtual ~SystemIndicatorDisableFunction() {}
+
+  virtual bool RunImpl() OVERRIDE;
+};
+
+}  // namespace extensions
+
+#endif  // CHROME_BROWSER_EXTENSIONS_API_SYSTEM_INDICATOR_SYSTEM_INDICATOR_API_H_