Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1023)

Side by Side Diff: chrome/renderer/resources/extensions/system_indicator_custom_bindings.js

Issue 11361189: Initial skeleton for System Indicator API (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Add manifest parsing and integrate with extension action api handlers. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Custom bindings for the browserAction API. 5 // Custom bindings for the browserAction API.
not at google - send to devlin 2012/11/21 23:39:23 update comment
dewittj 2012/11/26 18:32:58 Done.
6 6
7 var chromeHidden = requireNative('chrome_hidden').GetChromeHidden(); 7 var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();
8 var setIcon = require('setIcon').setIcon; 8 var setIcon = require('setIcon').setIcon;
9 9
10 chromeHidden.registerCustomHook('browserAction', function(bindingsAPI) { 10 chromeHidden.registerCustomHook('systemIndicator', function(bindingsAPI) {
not at google - send to devlin 2012/11/21 23:39:23 if you're up for a little bit of cleanup along the
not at google - send to devlin 2012/11/21 23:43:36 A good time for this might be in your follow-up.
dewittj 2012/11/26 18:32:58 OK.
11 var apiFunctions = bindingsAPI.apiFunctions; 11 var apiFunctions = bindingsAPI.apiFunctions;
12 12
13 apiFunctions.setHandleRequest('setIcon', function(details, callback) { 13 apiFunctions.setHandleRequest('setIcon', function(details, callback) {
14 setIcon(details, callback, this.name, this.definition.parameters, 14 setIcon(details, callback, this.name, this.definition.parameters,
15 'browser action'); 15 'system indicator');
16 }); 16 });
17 }); 17 });
18
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698