Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 // Custom bindings for the browserAction API. | 5 // Custom bindings for the browserAction API. |
|
not at google - send to devlin
2012/11/21 23:39:23
update comment
dewittj
2012/11/26 18:32:58
Done.
| |
| 6 | 6 |
| 7 var chromeHidden = requireNative('chrome_hidden').GetChromeHidden(); | 7 var chromeHidden = requireNative('chrome_hidden').GetChromeHidden(); |
| 8 var setIcon = require('setIcon').setIcon; | 8 var setIcon = require('setIcon').setIcon; |
| 9 | 9 |
| 10 chromeHidden.registerCustomHook('browserAction', function(bindingsAPI) { | 10 chromeHidden.registerCustomHook('systemIndicator', function(bindingsAPI) { |
|
not at google - send to devlin
2012/11/21 23:39:23
if you're up for a little bit of cleanup along the
not at google - send to devlin
2012/11/21 23:43:36
A good time for this might be in your follow-up.
dewittj
2012/11/26 18:32:58
OK.
| |
| 11 var apiFunctions = bindingsAPI.apiFunctions; | 11 var apiFunctions = bindingsAPI.apiFunctions; |
| 12 | 12 |
| 13 apiFunctions.setHandleRequest('setIcon', function(details, callback) { | 13 apiFunctions.setHandleRequest('setIcon', function(details, callback) { |
| 14 setIcon(details, callback, this.name, this.definition.parameters, | 14 setIcon(details, callback, this.name, this.definition.parameters, |
| 15 'browser action'); | 15 'system indicator'); |
| 16 }); | 16 }); |
| 17 }); | 17 }); |
| 18 | |
| OLD | NEW |