chrome/browser/extensions/api/system_indicator/system_indicator_api.cc - Issue 11361189: Initial skeleton for System Indicator API

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/api/system_indicator/system_indicator_api.cc

Issue 11361189: Initial skeleton for System Indicator API (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Add manifest parsing and integrate with extension action api handlers. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/extensions/api/extension_action/extension_actions_api.cc ('K') | « chrome/browser/extensions/api/system_indicator/system_indicator_api.h ('k') | chrome/browser/extensions/api/system_indicator/system_indicator_apitest.cc » ('j') | chrome/browser/extensions/extension_action_manager.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "chrome/browser/extensions/api/system_indicator/system_indicator_api.h"

	6

	7 #include "base/values.h"

	8 #include "chrome/browser/extensions/extension_service.h"

	9 #include "chrome/browser/extensions/extension_system.h"

	10 #include "chrome/browser/profiles/profile.h"

	11 #include "chrome/common/extensions/api/system_indicator.h"

	12

	13 namespace extensions {

	14

	15 bool SystemIndicatorEnableFunction::ValidateArguments() {

	16 // No arguments besides the callback.

	17 return true;
	not at google - send to devlin 2012/11/21 23:39:23 oh I didn't realise the reason for the change to V oh I didn't realise the reason for the change to ValidateArguments was in order to override it here. What ExtensionAction does is nearly good enough. They know how to deal with the lack of a tab ID property, so that's fine. I guess you just want to prevent APIs from adding a tab ID? In which case I'd just do that as a little check inside extension_actions_api.cc (there are already plenty of those for other things). That said, it's unlikely that the UI implementation will care about the tab ID, so eh. This validation is already being done on the renderer. The validation we do on the browser is only for sanity and security-important stuff, which the tab ID isn't. So yeah - I'd delete this stuff. dewittj 2012/11/26 18:32:58 Done. Show quoted text On 2012/11/21 23:39:23, kalman wrote: > oh I didn't realise the reason for the change to ValidateArguments was in order > to override it here. > > What ExtensionAction does is nearly good enough. They know how to deal with the > lack of a tab ID property, so that's fine. > > I guess you just want to prevent APIs from adding a tab ID? In which case I'd > just do that as a little check inside extension_actions_api.cc (there are > already plenty of those for other things). That said, it's unlikely that the UI > implementation will care about the tab ID, so eh. This validation is already > being done on the renderer. The validation we do on the browser is only for > sanity and security-important stuff, which the tab ID isn't. > > So yeah - I'd delete this stuff. Done.
	18 }

	19

	20 bool SystemIndicatorDisableFunction::ValidateArguments() {

	21 // No arguments besides the callback.

	22 return true;

	23 }

	24

	25 } // namespace extensions

OLD	NEW