Issue 11361172: Fix InternalObjectHashTable to properly update table ref in observationState

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11361172: Fix InternalObjectHashTable to properly update table ref in observationState (Closed)

Created:
8 years, 1 month ago by adamk

Modified:
8 years, 1 month ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix InternalObjectHashTable to properly update table ref in observationState The previous fix wasn't broad enough: it only fixed the reference for a single Context. Committed: https://code.google.com/p/v8/source/detail?r=12913

Patch Set 1 #

Patch Set 2 : Added test case #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -8 lines)			Patch
	M	src/object-observe.js	View		1 chunk	+8 lines, -8 lines	0 comments	Download
	M	test/cctest/test-object-observe.cc	View	1	1 chunk	+29 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

adamk

Still needs a test, but I have to figure out how to blow out the ...

8 years, 1 month ago (2012-11-08 17:27:54 UTC) #1

adamk

Added a test (and tested that the test fails without the patch).

8 years, 1 month ago (2012-11-09 09:15:41 UTC) #2

LGTM, gonna land it.

Expand Messages | Collapse Messages