Suppress sending mousedown / mouseup when in fling

content/browser/renderer_host/tap_suppression_controller_aura.cc

Index: content/browser/renderer_host/tap_suppression_controller_aura.cc
diff --git a/content/browser/renderer_host/tap_suppression_controller_aura.cc b/content/browser/renderer_host/tap_suppression_controller_aura.cc
index 8d3c39d79695dbce3d1f66451bc624b98b046192..a79fe8a56ec16819e06e6d54409b6f298e6329a3 100644
--- a/content/browser/renderer_host/tap_suppression_controller_aura.cc
+++ b/content/browser/renderer_host/tap_suppression_controller_aura.cc
@@ -132,8 +132,8 @@ void TapSuppressionController::GestureFlingCancelAck(bool processed) {
         TRACE_EVENT0("browser",
                      "TapSuppressionController::GestureFlingCancelAck");
         mouse_down_timer_.Stop();
-        render_widget_host_->ForwardMouseEvent(stashed_mouse_down_);
         state_ = NOTHING;

[mohsen, 2012/11/21 18:34:54]

If MouseDown is forwarded before setting the state_ to NOTHING, the
ShouldDeferMouseDown() method will be called while state_ is still set to
MD_STASHED, which is not desirable.

[rjkroege, 2012/11/21 20:41:18]

this is indeed an issue. TSC is not tested or intended to be recursive. I would
imagine that there might be other bugs of this kind in the future. I think it
would be better to add a RenderWidgetHostImpl::ForwardMouseEventImmediately
instead?

[mohsen, 2012/11/21 22:11:32]

I agree. The only problem is that most of the code for these two functions
(immediate and non-immediate) would be common. Maybe, we had better factor out
those common parts into another function or call the immediate one from inside
the non-immediate one, if it decides to forward the event. What do you think?

(BTW, I think the best solution is to somehow have a one-way relationship
between RWHI/GEF and TSC, i.e. only RWHI/GEF know of TSC.)

+        render_widget_host_->ForwardMouseEvent(stashed_mouse_down_);
       } // Else waiting for the timer to release the mouse event.
       break;
     case LAST_CANCEL_STOPPED_FLING:
@@ -164,8 +164,8 @@ void TapSuppressionController::MouseDownTimerExpired() {
     case MD_STASHED:
       TRACE_EVENT0("browser",
                    "TapSuppressionController::MouseDownTimerExpired");
-      render_widget_host_->ForwardMouseEvent(stashed_mouse_down_);
       state_ = NOTHING;

[mohsen, 2012/11/21 18:34:54]

The same as note under line 136.

+      render_widget_host_->ForwardMouseEvent(stashed_mouse_down_);
       break;
   }
 }