Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Issue 1136113003: Remove failure expectations (Closed)

Created:
5 years, 7 months ago by oshima
Modified:
5 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, pschmidt1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove failure expectations BUG=485183 R=kbr@chromium.org Committed: https://crrev.com/d2cfa0888b95054a256eace03e447761edeee6f5 Cr-Commit-Position: refs/heads/master@{#330484}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M content/test/gpu/gpu_tests/pixel_expectations.py View 1 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 25 (8 generated)
oshima
5 years, 7 months ago (2015-05-15 19:54:52 UTC) #1
Ken Russell (switch to Gerrit)
Thank you. Very good. LGTM +zmo, current GPU pixel wrangler
5 years, 7 months ago (2015-05-15 20:46:59 UTC) #2
Zhenyao Mo
LGTM
5 years, 7 months ago (2015-05-15 22:39:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136113003/1
5 years, 7 months ago (2015-05-16 01:14:53 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/65749)
5 years, 7 months ago (2015-05-16 03:34:54 UTC) #7
oshima
ken, the tests are still failing :( Any advice?
5 years, 7 months ago (2015-05-16 08:43:00 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136113003/1
5 years, 7 months ago (2015-05-16 08:43:32 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/65783)
5 years, 7 months ago (2015-05-16 10:52:01 UTC) #12
Ken Russell (switch to Gerrit)
On 2015/05/16 08:43:00, oshima wrote: > ken, the tests are still failing :( Any advice? ...
5 years, 7 months ago (2015-05-18 21:30:17 UTC) #13
Ken Russell (switch to Gerrit)
For the moment, please modify this CL to leave in failure expectations for Linux/NVIDIA, but ...
5 years, 7 months ago (2015-05-18 21:38:02 UTC) #14
Ken Russell (switch to Gerrit)
On 2015/05/18 21:38:02, Ken Russell wrote: > For the moment, please modify this CL to ...
5 years, 7 months ago (2015-05-19 01:09:02 UTC) #15
oshima
On 2015/05/19 01:09:02, Ken Russell wrote: > On 2015/05/18 21:38:02, Ken Russell wrote: > > ...
5 years, 7 months ago (2015-05-19 02:05:22 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136113003/20001
5 years, 7 months ago (2015-05-19 03:55:40 UTC) #19
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-19 06:06:49 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136113003/20001
5 years, 7 months ago (2015-05-19 06:14:33 UTC) #23
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-19 06:18:07 UTC) #24
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 06:18:57 UTC) #25
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d2cfa0888b95054a256eace03e447761edeee6f5
Cr-Commit-Position: refs/heads/master@{#330484}

Powered by Google App Engine
This is Rietveld 408576698