|
|
Created:
5 years, 7 months ago by oshima Modified:
5 years, 7 months ago CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, pschmidt1 Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove failure expectations
BUG=485183
R=kbr@chromium.org
Committed: https://crrev.com/d2cfa0888b95054a256eace03e447761edeee6f5
Cr-Commit-Position: refs/heads/master@{#330484}
Patch Set 1 #Patch Set 2 : #Messages
Total messages: 25 (8 generated)
Thank you. Very good. LGTM +zmo, current GPU pixel wrangler
LGTM
The CQ bit was checked by oshima@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136113003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
ken, the tests are still failing :( Any advice?
The CQ bit was checked by oshima@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136113003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
On 2015/05/16 08:43:00, oshima wrote: > ken, the tests are still failing :( Any advice? oshima@ : this presents a major problem. It looks like some of the GPU bots are configured differently than others, and a different DPI is being reported to X on some bots vs. others. We need to discuss this offline with pschmidt@.
For the moment, please modify this CL to leave in failure expectations for Linux/NVIDIA, but to expect the tests to pass on the other platforms. Right now we're flying completely blind with regard to pixel testing.
On 2015/05/18 21:38:02, Ken Russell wrote: > For the moment, please modify this CL to leave in failure expectations for > Linux/NVIDIA, but to expect the tests to pass on the other platforms. Right now > we're flying completely blind with regard to pixel testing. oshima: could you please rebase this CL and send it to the try bots again? It should pass as soon as the waterfalls have generated new reference images for the Linux/NVIDIA bots.
On 2015/05/19 01:09:02, Ken Russell wrote: > On 2015/05/18 21:38:02, Ken Russell wrote: > > For the moment, please modify this CL to leave in failure expectations for > > Linux/NVIDIA, but to expect the tests to pass on the other platforms. Right > now > > we're flying completely blind with regard to pixel testing. > > oshima: could you please rebase this CL and send it to the try bots again? It > should pass as soon as the waterfalls have generated new reference images for > the Linux/NVIDIA bots. will do
The CQ bit was checked by oshima@chromium.org to run a CQ dry run
The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org, zmo@chromium.org Link to the patchset: https://codereview.chromium.org/1136113003/#ps20001 (title: " ")
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136113003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by oshima@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136113003/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/d2cfa0888b95054a256eace03e447761edeee6f5 Cr-Commit-Position: refs/heads/master@{#330484} |