Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 11361125: Support running Android apk-based tests under ASan. (Closed)

Created:
8 years, 1 month ago by eugenis
Modified:
8 years, 1 month ago
CC:
chromium-reviews, pam+watch_chromium.org, yfriedman+watch_chromium.org, timurrrr+watch_chromium.org, bulach+watch_chromium.org, peter+watch_chromium.org, glider+watch_chromium.org, ilevy+watch_chromium.org, bruening+watch_chromium.org
Visibility:
Public.

Description

Support running Android apk-based tests under ASan. BUG=137569 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=166394

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -11 lines) Patch
M build/android/pylib/test_package_apk.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M build/android/pylib/valgrind_tools.py View 1 2 3 chunks +12 lines, -11 lines 0 comments Download
A tools/android/asan/asanwrapper.sh View 1 2 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
eugenis
8 years, 1 month ago (2012-11-06 16:02:49 UTC) #1
eugenis
This thing will not work just yet, it needs one more clang roll, but I ...
8 years, 1 month ago (2012-11-06 16:05:54 UTC) #2
Isaac (away)
Note that android clang bots are not being rolled due to http://llvm.org/bugs/show_bug.cgi?id=11709 & crbug.com/156947
8 years, 1 month ago (2012-11-06 19:27:17 UTC) #3
hwennborg
On Tue, Nov 6, 2012 at 11:27 AM, <ilevy@chromium.org> wrote: > Note that android clang ...
8 years, 1 month ago (2012-11-06 19:33:43 UTC) #4
bulach
lgtm, thanks! a note for ilevy below. http://codereview.chromium.org/11361125/diff/6001/build/android/pylib/valgrind_tools.py File build/android/pylib/valgrind_tools.py (right): http://codereview.chromium.org/11361125/diff/6001/build/android/pylib/valgrind_tools.py#newcode118 build/android/pylib/valgrind_tools.py:118: self._adb.EnableAdbRoot() ilevy: ...
8 years, 1 month ago (2012-11-07 11:37:45 UTC) #5
Isaac (away)
Do you mean on the internal waterfall? External clang bot is builder only.
8 years, 1 month ago (2012-11-13 10:35:16 UTC) #6
eugenis
8 years, 1 month ago (2012-11-13 10:57:46 UTC) #7
On 2012/11/13 10:35:16, Isaac wrote:
> Do you mean on the internal waterfall?  External clang bot is builder only.

We want an ASan builder/tester on the external waterfall, if there is enough
hardware available for this.

Powered by Google App Engine
This is Rietveld 408576698