Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/variable_allocator.dart

Issue 11361100: Remove hack around aborting loop body in the case of for loops and while loops. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/ssa/variable_allocator.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/ssa/variable_allocator.dart (revision 14539)
+++ sdk/lib/_internal/compiler/implementation/ssa/variable_allocator.dart (working copy)
@@ -295,6 +295,11 @@
void updateLoopMarker(HBasicBlock header) {
LiveEnvironment env = liveInstructions[header];
int lastId = env.loopMarkers[header];
+ if (lastId == null) {
+ assert(header.predecessors.length == 1);
floitsch 2012/11/05 17:36:09 add comment what happened.
ngeoffray 2012/11/06 08:55:27 I changed the code to not enter updateLoopMarker i
+ return;
+ }
+
// Update all instructions that are liveIns in [header] to have a
// range that covers the loop.
env.liveInstructions.forEach((HInstruction instruction, int id) {

Powered by Google App Engine
This is Rietveld 408576698