Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/builder.dart

Issue 11361098: Add a check for issue 6530, so that we don't report errors in checked mode on a void return type. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/ssa/builder.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/ssa/builder.dart (revision 14527)
+++ sdk/lib/_internal/compiler/implementation/ssa/builder.dart (working copy)
@@ -3459,7 +3459,12 @@
} else {
visit(node.expression);
value = pop();
- value = potentiallyCheckType(value, returnType);
+ if (returnType == compiler.types.voidType
+ && value is HForeign) {
+ // TODO(6530): remove this check.
+ } else {
+ value = potentiallyCheckType(value, returnType);
+ }
}
if (!inliningStack.isEmpty) {
localsHandler.updateLocal(returnElement, value);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698