Fix issue 6472 that exhibited a few crashing bugs in dart2js.

lib/compiler/implementation/universe/universe.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library universe;
 
 import '../closure.dart';
 import '../elements/elements.dart';
 import '../dart2jslib.dart';
 import '../runtime_types.dart';
@@ skipping 404 matching lines @@
     // A closure can be called through any typed selector:
     // class A {
     //   get foo => () => 42;
     //   bar() => foo(); // The call to 'foo' is a typed selector.
     // }
     ClassElement other = element.getEnclosingClass();
     if (identical(other.superclass, compiler.closureClass)) {
       return appliesUntyped(element, compiler);
     }
 
     ClassElement self = receiverType.element;

[ahe, 2012/11/05 08:33:32]

Doesn't this fail in checked mode?

[ngeoffray, 2012/11/05 10:51:03]

Good catch. The test I wrote was not complete. 

 
     if (other.implementsInterface(self)
         || other.isSubclassOf(self)
         || compiler.world.hasAnySubclassThatImplements(other, receiverType)) {
       return appliesUntyped(element, compiler);
     }
 
-    if (!self.isInterface() && self.isSubclassOf(other)) {
+    if (!self.isTypedef() && !self.isInterface() && self.isSubclassOf(other)) {

[ahe, 2012/11/05 08:33:32]

I think it would be better with a positive test, such as: self.isClass(). Also,
I'm not sure the value of testing for isInterface as classes can be used as
interfaces as well.

[ngeoffray, 2012/11/05 10:51:03]

Done.

       // Resolve an invocation of [element.name] on [self]. If it
       // is found, this selector is a candidate.
       return hasElementIn(self, element) && appliesUntyped(element, compiler);
     }
 
     return false;
   }
 }