Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1867)

Unified Diff: content/common/browser_plugin_messages.h

Issue 11361052: Browser Plugin: Implement autosize (Embedder-side code) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/browser_plugin_messages.h
diff --git a/content/common/browser_plugin_messages.h b/content/common/browser_plugin_messages.h
index ea4d847559a79409f6bf0331cce79f92ad82a3a3..0d7bc266263ad23f96eefb8069c9b4557b1cef15 100644
--- a/content/common/browser_plugin_messages.h
+++ b/content/common/browser_plugin_messages.h
@@ -34,15 +34,34 @@ IPC_ENUM_TRAITS(WebKit::WebDragStatus)
// -----------------------------------------------------------------------------
// These messages are from the embedder to the browser process.
+// This message is sent to the browser process to enable or disable autosize
jam 2012/11/02 19:11:10 nit: put this comment on the IPC_MESSAGE, not the
Fady Samuel 2012/11/02 20:32:23 Done.
+// mode.
+IPC_STRUCT_BEGIN(BrowserPluginHostMsg_AutoSize_Params)
jam 2012/11/02 19:11:10 nit: structs go at the top of the file and not by
Fady Samuel 2012/11/02 20:32:23 Done.
+ IPC_STRUCT_MEMBER(int, enable)
+ IPC_STRUCT_MEMBER(int, maxheight)
jam 2012/11/02 19:11:10 max_height
Fady Samuel 2012/11/02 20:32:23 Done.
+ IPC_STRUCT_MEMBER(int, maxwidth)
+ IPC_STRUCT_MEMBER(int, minheight)
+ IPC_STRUCT_MEMBER(int, minwidth)
+IPC_STRUCT_END()
+
+IPC_MESSAGE_ROUTED2(BrowserPluginHostMsg_SetAutoSize,
+ int /* instance_id */,
+ BrowserPluginHostMsg_AutoSize_Params)
+
+IPC_STRUCT_BEGIN(BrowserPluginHostMsg_CreateGuest_Params)
+ IPC_STRUCT_MEMBER(std::string, storage_partition_id)
+ IPC_STRUCT_MEMBER(bool, persist_storage)
+ IPC_STRUCT_MEMBER(bool, focused)
+ IPC_STRUCT_MEMBER(bool, visible)
+ IPC_STRUCT_MEMBER(BrowserPluginHostMsg_AutoSize_Params, autosize)
+IPC_STRUCT_END()
+
// This message is sent to the browser process to create the browser plugin
// embedder and helper. It is sent once prior to sending the first
// BrowserPluginHostMsg_NavigateGuest message.
-IPC_MESSAGE_ROUTED5(BrowserPluginHostMsg_CreateGuest,
+IPC_MESSAGE_ROUTED2(BrowserPluginHostMsg_CreateGuest,
int /* instance_id */,
- std::string /* storage_partition_id */,
- bool /* persist_storage */,
- bool /* focused */,
- bool /* visible */)
+ BrowserPluginHostMsg_CreateGuest_Params /* params */)
// Tells the browser process to terminate the guest associated with the
// browser plugin associated with the provided |instance_id|.

Powered by Google App Engine
This is Rietveld 408576698