Browser Plugin: Implement autosize (Embedder-side code)

content/common/browser_plugin_messages.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Multiply-included message header, no traditional include guard.
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/process.h"
@@ skipping 16 matching lines @@
 
 #define IPC_MESSAGE_START BrowserPluginMsgStart
 
 IPC_ENUM_TRAITS(WebKit::WebDragStatus)
 
 // Browser plugin messages
 
 // -----------------------------------------------------------------------------
 // These messages are from the embedder to the browser process.
 
+// This message is sent to the browser process to enable or disable autosize

[jam, 2012/11/02 19:11:10]

nit: put this comment on the IPC_MESSAGE, not the struct

[Fady Samuel, 2012/11/02 20:32:23]

Done.

+// mode.
+IPC_STRUCT_BEGIN(BrowserPluginHostMsg_AutoSize_Params)

[jam, 2012/11/02 19:11:10]

nit: structs go at the top of the file and not by the messages (i.e. at line 30)

[Fady Samuel, 2012/11/02 20:32:23]

Done.

+  IPC_STRUCT_MEMBER(int, enable)
+  IPC_STRUCT_MEMBER(int, maxheight)

[jam, 2012/11/02 19:11:10]

max_height

[Fady Samuel, 2012/11/02 20:32:23]

Done.

+  IPC_STRUCT_MEMBER(int, maxwidth)
+  IPC_STRUCT_MEMBER(int, minheight)
+  IPC_STRUCT_MEMBER(int, minwidth)
+IPC_STRUCT_END()
+
+IPC_MESSAGE_ROUTED2(BrowserPluginHostMsg_SetAutoSize,
+                    int /* instance_id */,
+                    BrowserPluginHostMsg_AutoSize_Params)
+
+IPC_STRUCT_BEGIN(BrowserPluginHostMsg_CreateGuest_Params)
+  IPC_STRUCT_MEMBER(std::string, storage_partition_id)
+  IPC_STRUCT_MEMBER(bool, persist_storage)
+  IPC_STRUCT_MEMBER(bool, focused)
+  IPC_STRUCT_MEMBER(bool, visible)
+  IPC_STRUCT_MEMBER(BrowserPluginHostMsg_AutoSize_Params, autosize)
+IPC_STRUCT_END()
+
 // This message is sent to the browser process to create the browser plugin
 // embedder and helper. It is sent once prior to sending the first
 // BrowserPluginHostMsg_NavigateGuest message.
-IPC_MESSAGE_ROUTED5(BrowserPluginHostMsg_CreateGuest,
+IPC_MESSAGE_ROUTED2(BrowserPluginHostMsg_CreateGuest,
                     int /* instance_id */,
-                    std::string /* storage_partition_id */,
-                    bool /* persist_storage */,
-                    bool /* focused */,
-                    bool /* visible */)
+                    BrowserPluginHostMsg_CreateGuest_Params /* params */)
 
 // Tells the browser process to terminate the guest associated with the
 // browser plugin associated with the provided |instance_id|.
 IPC_MESSAGE_ROUTED1(BrowserPluginHostMsg_TerminateGuest,
                     int /* instance_id */)
 
 // Tells the guest to navigate to an entry |relative_index| away from the
 // current navigation entry.
 IPC_MESSAGE_ROUTED2(BrowserPluginHostMsg_Go,
                     int /* instance_id */,
@@ skipping 204 matching lines @@
 IPC_MESSAGE_CONTROL2(BrowserPluginMsg_ShouldAcceptTouchEvents,
                      int /* instance_id */,
                      bool /* accept */)
 
 // The guest has damage it wants to convey to the embedder so that it can
 // update its backing store.
 IPC_MESSAGE_CONTROL3(BrowserPluginMsg_UpdateRect,
                      int /* instance_id */,
                      int /* message_id */,
                      BrowserPluginMsg_UpdateRect_Params)