editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/TypeContextChecker.java - Issue 11361018: Cascade should have type set. Tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/TypeContextChecker.java

Issue 11361018: Cascade should have type set. Tests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java ('k') | editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/refactoring/ExtractMethodRefactoringTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/TypeContextChecker.java

diff --git a/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/TypeContextChecker.java b/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/TypeContextChecker.java

index b3751459f720dd0f5c8cf397d1eff0449a11271c..db0eb9ffec6855406069290b7fc25218b6a0574b 100644

--- a/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/TypeContextChecker.java

+++ b/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/TypeContextChecker.java

@@ -441,8 +441,8 @@ public class TypeContextChecker {

public static RefactoringStatus checkParameterTypeSyntax(String newTypeName, CompilationUnit unit) {

newTypeName = newTypeName.trim();

- // empty == Dynamic

- if (newTypeName.isEmpty()) {

+ // empty or dynamic == no type

+ if (newTypeName.isEmpty() || "dynamic".equals(newTypeName)) {

return new RefactoringStatus();

// String msg = Messages.format(

// RefactoringCoreMessages.TypeContextChecker_parameter_type,